Skip to content

Learning Hub Follow-Up#2491

Merged
camielvs merged 1 commit into
masterfrom
07-06-learning_hub_follow-up
Jul 7, 2026
Merged

Learning Hub Follow-Up#2491
camielvs merged 1 commit into
masterfrom
07-06-learning_hub_follow-up

Conversation

@camielvs

@camielvs camielvs commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Description

Addresses various items raised in Slack.

  • fix onboarding badge re-mounting ever page load
  • add a "dismiss onboarding" button to the onboarding popover (can also already be dismissed via the learning hub)
  • the tour popover backdrop now blocks clicks
  • custom window layouts should now be preserved - tours will use a different layout key in storage
  • settings modal is now closable

Related Issue and Pull requests

Type of Change

  • Bug fix
  • Improvement
  • Cleanup/Refactor

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

image.png

Test Instructions

Additional Comments

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

🎩 Preview

A preview build has been created at: 07-06-learning_hub_follow-up/3fea8f9

camielvs commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator Author

This was referenced Jul 7, 2026
@camielvs camielvs marked this pull request as ready for review July 7, 2026 02:01
@camielvs camielvs requested a review from a team as a code owner July 7, 2026 02:01
@camielvs camielvs added the #gsd:50583 Learning Hub label Jul 7, 2026 — with Graphite App
Comment thread src/providers/TourProvider/TourSecretsDialog.tsx Outdated
@camielvs camielvs force-pushed the 07-06-learning_hub_follow-up branch 2 times, most recently from 07244d0 to 0508084 Compare July 7, 2026 17:52

camielvs commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator Author

Merge activity

  • Jul 7, 5:57 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jul 7, 7:37 PM UTC: Graphite rebased this pull request as part of a merge.
  • Jul 7, 7:40 PM UTC: @camielvs merged this pull request with Graphite.

@camielvs camielvs changed the base branch from 06-18-feat_onboarding_welcome_page to graphite-base/2491 July 7, 2026 19:31
@camielvs camielvs changed the base branch from graphite-base/2491 to master July 7, 2026 19:35
@camielvs camielvs force-pushed the 07-06-learning_hub_follow-up branch from 0508084 to 3fea8f9 Compare July 7, 2026 19:36
@camielvs camielvs merged commit 8b29242 into master Jul 7, 2026
17 checks passed
@camielvs camielvs deleted the 07-06-learning_hub_follow-up branch July 7, 2026 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

#gsd:50583 Learning Hub

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants