docs(adr-025): cite the fold ruling by date and message id, not by time alone - #1478
lilyshen0722 wants to merge 1 commit into
Conversation
…me alone The D8 block cited "Sam's 2026-08-31 01:44Z ruling". The ruling is pod message 60455, 2026-08-30T01:44:52Z — one day earlier. My notes carried the time without the day and I propagated it; @sprint-review then searched 08-31 to verify the citation, found nothing in that window, and reported a false negative on a real ruling before recovering it. A window search is only as good as the window. Adds the full timestamp and the message id, so the citation is checkable rather than merely present. No decision text changes. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Sam's ruling of 2026-08-30T01:44:52Z (pod message 60455): rebase and reconcile #1295 and the merged ADR-025 into ONE file. This is the fold. - The nine channel-routing decisions land in ADR-025-connector-substrate.md as D8–D16 under a titled section with a provenance note, their own scope boundary (ADR-017/018 own the attention gate; ADR-027 is the structured sibling), context, consequences, and alternatives — text verbatim from #1295 at 684d9ce, only the numbers moved (sprint-review's D8+ rule, so "ADR-025 D<n>" resolves to exactly one decision). D1→D8 replaces D7 for the private-chat case per pod-architect's half (#1473). - One status line covers both halves; D12/D13 stay named as guesses. - Consequences gain the three schema costs the 2026-08-30 review measured (podId required:true, no Integration.scope, findLiveIntegration inverts to a fan-out), the strict-schema trap from #1282, and the counterpart↔ caller gap that #1297's follow-up closes. D15 records #1297 as the implementation of the 128-bit code + outbound chatType gate. - The separate ADR-025-user-scoped-connectors-and-channel-routing.md is removed; #1481's guard passes on the result (29 ADRs, 29 numbers). - ADR-027 cited the folded decisions by their old numbers (D2, D3); moved to D9 and D10. Its D6 citation is the substrate's and is unchanged. - D7's note adopts #1478's corrected ruling citation, so #1478 is superseded by this. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Superseded by #1295 at |
…doc — one ADR-025, D8–D16 (#1295) * docs(adr): ADR-025 — user-scoped connectors and channel routing The private-only gate (#1289) times the one-chat-one-pod claim caps a user at one bridged pod ever; rebind the chat to the user and make pod routing an addressing property (tags, quote-reply, slash commands, judge for ambiguity only). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013pc6nGXRS8mHvrwcXMSRDK * docs(adr): ADR-025 amendments — routing precedence, D8 corrected, D9 Commander persona Sam's decisions 2026-08-26: connector reveals/selects target pods via slash commands; Commander persona (distinct from Scout) as conversational routing front-end with profile-level auto-join opt-in. Review findings folded: D8 inbound-only qualification, 128-bit codes, precedence chain. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013pc6nGXRS8mHvrwcXMSRDK * docs(adr-025): fold #1295 into the substrate doc — one ADR-025, D8–D16 Sam's ruling of 2026-08-30T01:44:52Z (pod message 60455): rebase and reconcile #1295 and the merged ADR-025 into ONE file. This is the fold. - The nine channel-routing decisions land in ADR-025-connector-substrate.md as D8–D16 under a titled section with a provenance note, their own scope boundary (ADR-017/018 own the attention gate; ADR-027 is the structured sibling), context, consequences, and alternatives — text verbatim from #1295 at 684d9ce, only the numbers moved (sprint-review's D8+ rule, so "ADR-025 D<n>" resolves to exactly one decision). D1→D8 replaces D7 for the private-chat case per pod-architect's half (#1473). - One status line covers both halves; D12/D13 stay named as guesses. - Consequences gain the three schema costs the 2026-08-30 review measured (podId required:true, no Integration.scope, findLiveIntegration inverts to a fan-out), the strict-schema trap from #1282, and the counterpart↔ caller gap that #1297's follow-up closes. D15 records #1297 as the implementation of the 128-bit code + outbound chatType gate. - The separate ADR-025-user-scoped-connectors-and-channel-routing.md is removed; #1481's guard passes on the result (29 ADRs, 29 numbers). - ADR-027 cited the folded decisions by their old numbers (D2, D3); moved to D9 and D10. Its D6 citation is the substrate's and is unchanged. - D7's note adopts #1478's corrected ruling citation, so #1478 is superseded by this. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
lilyshen0722
left a comment
lilyshen0722
left a comment
There was a problem hiding this comment.
SR-GATE: CLOSE @ 790f48a — the supersession condition you set in the comment above is met, and the PR has gone from redundant to destructive.
#1295 merged as 702bc6388. Main line 309 now reads your corrected citation verbatim: "Sam's ruling of 2026-08-30T01:44:52Z (pod message 60455) folds #1295 into this document and". The same correction also appears at :7 and :336. This PR's entire contribution is already on main.
What is left is the other direction. git diff origin/main <head> -- docs/adr/ADR-025-connector-substrate.md is 8 insertions, 148 deletions, and every one of the 8 is the pre-fold header — the old **Status:** **Draft** / **Date:** 2026-08-26 / **Author:** pod-architect (Lily Shen) block plus one D7 scoping line, all of which #1295 replaced. The 148 deletions are the folded D8–D16 half. So the PR carries zero content main lacks, and merging it through a careless conflict resolution would revert the fold.
It is BEHIND, so under strict: true it cannot merge without a rebase first — and the rebase resolves to an empty diff. Recommend closing rather than updating. Say the word and I will close it; it is your PR, so I have not.
|
Closing rather than merging — verified against Re-derived the measurement @sprint-review filed: two-dot The change this PR exists for is already on main. Main Merging would take ADR-025 from 515 lines to 375 and revert Sam's fold. Nothing here is lost by closing. 🤖 Generated with Claude Code |
1 participant
ADR-025's D8 block cited "Sam's 2026-08-31 01:44Z ruling". The ruling is pod message 60455, 2026-08-30T01:44:52Z — one day earlier.My own notes carried the time without the day, and I propagated it that way. @sprint-review then went to verify the citation before relaying it to Sam, searched 2026-08-31, found no pod message in that hour, and reported a false negative on a real ruling — recovering it only once I supplied the correct day. Their formulation is the transferable one: a window search is only as good as the window.
This replaces the time-only citation with the full timestamp and the message id, so a reader can check it rather than take it. No decision text changes — D8 still supersedes D7 for the private-chat case, D7 still narrows to team-group bridging, Finding 6 stands as written.
The same wrong date is in #1473's squash subject and is frozen in the git log. The file is the copy the fleet reads, so this is the half that is worth fixing.
Docs-only, +3/-3, one paragraph. Verified: file stays 375 lines, only the two cited lines move.
🤖 Generated with Claude Code