Skip to content

[frontend] Reset BYO hint paragraph margins - #1657

Draft
thantiklermcirony wants to merge 2 commits into
Team-Commonly:mainfrom
thantiklermcirony:fix/byo-hint-paragraph-margins
Draft

thantiklermcirony wants to merge 2 commits into
Team-Commonly:mainfrom
thantiklermcirony:fix/byo-hint-paragraph-margins

Conversation

@thantiklermcirony

Copy link
Copy Markdown

Summary

Reset .v2-byo__hint margins so paragraph hints in BYO flex layouts use the components' explicit gaps. Add the required layout-invariant guard. This implements the one-line fix proposed and measured in the issue by lilyshen0722.

Type

  • Bug fix

Related Issues

Closes #1413

Test Plan

  • Focused repository Jest suite: v2-layout-invariants.test.ts — 109/109 passed.
  • ESLint on the changed test — zero errors; six warnings on existing lines.
  • Real Chromium layout check using the actual stylesheet and current markup patterns.
  • Presence-guard mutation check and clean patch-application check.
  • Published files match the tested local files byte-for-byte.
  • Full authoritative frontend test/lint run.
  • Full stack / backend checks and ./dev.sh up (not run).

Browser measurements, in pixels:

Layout Before After
Hosted stats → hint 30 18
Hosted hint → CTA 38 26
Memory hint → textarea 22 10
Add-computer adjacent gaps 18 6
Existing span top/bottom margins 0 / 0 0 / 0

The memory and add-computer paragraphs consequently become tighter, matching their parents' declared gaps. The hosted CTA still has its existing additional 8px top margin.

Notes for Reviewer

Draft while full validation is unresolved. Full frontend lint reports 20 errors in existing files outside this diff. An isolated pnpm install with lifecycle scripts and lockfile writing disabled ran 60 passing suites / 531 passing tests, but other suites encountered DiceBear ESM transform and missing prop-types resolution problems under that installation topology. This is not a clean full-suite result; the repository's normal npm/CI run is still needed. No manifest or lockfile was changed.

The public design README and surrounding CSS were checked. The referenced external commonly-design skill is absent from the public archive. The change follows the existing sibling paragraph margin reset and the issue's proposed repair.

Implemented by OpenAI Codex, directed by Daniel J. Murray.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v2: .v2-byo__hint lacks margin:0, adding 24px to the hosted panel after #1412's span→p change

1 participant