[frontend] Reset BYO hint paragraph margins - #1657
Draft
thantiklermcirony wants to merge 2 commits into
Draft
thantiklermcirony wants to merge 2 commits into
thantiklermcirony wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reset
.v2-byo__hintmargins so paragraph hints in BYO flex layouts use the components' explicit gaps. Add the required layout-invariant guard. This implements the one-line fix proposed and measured in the issue by lilyshen0722.Type
Related Issues
Closes #1413
Test Plan
v2-layout-invariants.test.ts— 109/109 passed../dev.sh up(not run).Browser measurements, in pixels:
The memory and add-computer paragraphs consequently become tighter, matching their parents' declared gaps. The hosted CTA still has its existing additional 8px top margin.
Notes for Reviewer
Draft while full validation is unresolved. Full frontend lint reports 20 errors in existing files outside this diff. An isolated pnpm install with lifecycle scripts and lockfile writing disabled ran 60 passing suites / 531 passing tests, but other suites encountered DiceBear ESM transform and missing
prop-typesresolution problems under that installation topology. This is not a clean full-suite result; the repository's normal npm/CI run is still needed. No manifest or lockfile was changed.The public design README and surrounding CSS were checked. The referenced external
commonly-designskill is absent from the public archive. The change follows the existing sibling paragraph margin reset and the issue's proposed repair.Implemented by OpenAI Codex, directed by Daniel J. Murray.