Skip to content

[frontend] Reset BYO hint paragraph margins #1657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
thantiklermcirony wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[frontend] Reset BYO hint paragraph margins #1657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8bba7f
fix(frontend): reset BYO hint paragraph margins
thantiklermcirony Sep 11, 2026
3b043ae
test(frontend): guard BYO hint spacing invariant
thantiklermcirony Sep 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions frontend/src/v2/__tests__/v2-layout-invariants.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,10 @@ describe('v2 layout invariants (CSS rule presence)', () => {
const appsManagement = read('../../components/AppsManagement.tsx');
const podModel = read('../../../../backend/models/Pod.ts');

test('BYO hints do not add paragraph margins to flex gaps', () => {
expect(ruleBody(v2, '.v2-byo__hint')).toContain('margin: 0');
});

test('Your Team card name owns its line so the category chip cannot crush it', () => {
// Direction C: the name sits in its own column of the card head; the
// crush guard is min-width 0 on the name and the head, not a flex basis.
Expand Down
1 change: 1 addition & 0 deletions frontend/src/v2/v2.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5694,6 +5694,7 @@ body.modern-ui.v2-canvas {
.v2-byo__hint {
font-size: 12px;
color: var(--v2-text-tertiary);
margin: 0;
}
.v2-byo__error {
padding: 10px 12px;
Expand Down