Repository navigation
Keep the window level after an Enter-chat error - #1097
Merged
Merged
Conversation
Dismissing the error and typing in the room composer left the window scrolled sideways. Clip horizontal overflow on the document and the app frame, put a leftover scrollLeft back when the composer is used, and center the error toast inside the viewport. The Enter-chat Internal error itself stays #1085. Co-authored-by: Danyang Chen <birfychen@gmail.com>
cursor
Bot
force-pushed
the
cursor/face-room-layout-clip-0518
branch
from
October 25, 2026 02:39
cfd3d38 to
5cb9580
Compare
Collaborator
Author
|
Verdict: PASS at 5cb9580 Fixes #1086. Rebased tip: shell overflow-x clip + scrollLeft reset; shell-level.test.js in patch series; ds-bot-patches check green. Ran:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Written-by: Dev
Owner: Dev
Reviewer: Reviewer
Fixes #1086
What changed
Dismissing the Enter-chat error and typing in the room composer left the B window scrolled sideways until reload. The page, the conversation column, and the app frame now use
overflow-x:clip(overflow:hiddenstill honorsscrollLeft). Focusing or typing in the composer puts a leftoverscrollLeftback on the page and on the composer's ancestors, twice across frames. The error toast is centered with auto margins, so its box stays inside the viewport.#1085 is the Internal error itself. Enter chat already catches that failure into the room, and the string is not a client throw, so this pull request does not close #1085. It hardens the shell so that dialog or toast cannot leave the window clipped.
The shell-level test is stored whole in
patches/ds-bot/files/test/shell-level.test.js.Rebased onto
mainat942a7ff96b0bef54f00af5b584ca5932d75cf0c6(#1094). The only conflict waspatches/ds-bot/0008-client-bundle.patch. Sources auto-merged (the clip sits beside the mention look and the remote-approval phrase).client.jswas rebuilt from those sources. Patches were regenerated;0012-room-membership.patchwas left as onmainbecause that copy still reproducescore/.Verification at the tip
Tip SHA: 5cb9580
Fail-without-change: on the unbroken tip,
node --test test/shell-level.test.jsfailed becausepanes.jsdid not exportlevelShell. After the source change and beforeclient.jswas rebuilt, the bundle assertion failed (client.js carries the document clip) while the scrollLeft cases passed. At this tip all 5 tests incore/test/shell-level.test.jspass.Ran:
TZ=UTC npm run verify(exit 0) at5cb9580b133c531f91f6043b73b4ae9bef1e6271.node scripts/ds-bot-patches.mjs checkok (10 patches apply, core equals ds-bot + patches). core 1437 pass / 0 fail / 0 skipped, social 471 pass, tree 125 pass, timeline 125 pass, .github/scripts 417 pass, interop 37 pass, live-e2e 16 pass. arch-docs OK (12 changed files).node core/scripts/build-client.mjs --checkok.git diff origin/main...HEAD --statlists only this change.Not run: smoke (no
core/index.jsorsrc/host/change). Desktop. Browser (no app server; the clip and the scrollLeft reset are covered bycore/test/shell-level.test.js).Self-review note
Implementer only. No
Verdict:. The previous tipcfd3d387was DIRTY againstmain; this tip is rebased onto942a7ff.patches/ds-bot/files/test/shell-level.test.jsis still the byte-for-byte copy ofcore/test/shell-level.test.js. PASS and enqueue stay with the coordinator.Not enqueued.