Repository navigation
Draw each face-room member with their chat look - #1107
Merged
Merged
Conversation
Room details painted one letter S for every home that shares an initial. Member rows now use the same Bot mark as the transcript and the sidebar. Fixes #1104 Co-authored-by: Danyang Chen <birfychen@gmail.com>
Collaborator
Author
|
Verdict: PASS at 2c30879 Fixes #1104. Face-room member rows draw each seat's chat Bot mark (local roster look, or friend's look stepped off a same-named local Bot) instead of one shared person initial. Empty seat still uses PersonMark (#1089). Ran:
|
Birfy
enabled auto-merge
October 25, 2026 04:40
Birfy
added a commit
that referenced
this pull request
Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Written-by: Dev
Owner: Dev
Reviewer: Reviewer
Fixes #1104
Face room details drew one letter S for SelfA1025 and SelfB1025. Member rows now draw each seat with the chat and sidebar Bot mark: the local roster look, or a friend's look stepped off a same-named local Bot. A row with no Bot still draws the person silhouette, never a blank disc (#1089). Outgoing person bubbles stay initials.
Fail-without-change: on base b77f744,
cd core && node --test test/face-member-avatar.test.jswith the new test and the old FacePersonRow — test 2 actual[]vs expected['whale'], test 30 !== 1. The same command is green after the source change.Tip SHA: 2c30879
Ran: TZ=UTC npm run verify (exit 0)
Not run: smoke bench, desktop, and the live room 739184 UI.