Repository navigation
Conversation
samgbafa
force-pushed
the
skgbafa/tc-1149-revoke-cascade
branch
from
October 15, 2026 18:54
a9507bb to
95dc940
Compare
samgbafa
commented
Oct 15, 2026
samgbafa
left a comment
samgbafa
left a comment
Contributor
Author
There was a problem hiding this comment.
REQUEST_CHANGES — TC-1149
Contributor
Author
|
REQUEST_CHANGES: see TC-1149 |
Contributor
Author
|
REQUEST_CHANGES: see TC-1149 |
samgbafa
commented
Oct 15, 2026
samgbafa
left a comment
samgbafa
left a comment
Contributor
Author
There was a problem hiding this comment.
REQUEST_CHANGES — TC-1149
Separate full historical witness validation from live policy cutoff; align principal locks and maintain typed admission errors. Remove a brittle source-inspection test while retaining runtime DID route coverage. Verified Rust workspace (1129), M1 (13), SDK localhost (21), formatting and strict Clippy.
Contributor
Author
|
APPROVE: see TC-1149 |
Contributor
Author
|
APPROVE: see TC-1149 |
samgbafa
commented
Oct 16, 2026
samgbafa
left a comment
samgbafa
left a comment
Contributor
Author
There was a problem hiding this comment.
APPROVE — TC-1149
Contributor
Author
|
REQUEST_CHANGES: see TC-1149 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds signed key-principal revocation, durable receipts, policy authority witnesses, and route authorization checks.
Normally merged the latest tested #291 base. Checks: 1,145 workspace tests with PostgreSQL and MySQL fixtures, 13 real-data tests, 10 DuckDB integrations, 21 SDK-to-localhost cases, format, and strict Clippy. Exact-head CI is running through the guarded CI-only #304; fresh reviews and release gates remain.
Related: TC-1149.