Add confirmed family members and reverse DNS details to relay dialog#451
Closed
center2055 wants to merge 1 commit intoTorMap:masterfrom
Closed
Add confirmed family members and reverse DNS details to relay dialog#451center2055 wants to merge 1 commit intoTorMap:masterfrom
center2055 wants to merge 1 commit intoTorMap:masterfrom
Conversation
Member
|
Hey @center2055 thanks a lot for your PR! I just saw it and will review this week :) |
Author
|
Alright thanks a lot! |
There was a problem hiding this comment.
Pull request overview
This PR enriches the relay details endpoint and UI by adding confirmed family members and reverse-DNS-derived hostnames (verified vs unverified), with backend caching for DNS lookups.
Changes:
- Added backend reverse-DNS lookup service with caching and exposed verified/unverified hostnames in relay details responses.
- Added backend relay-details query service and DTO to include confirmed family members plus reverse-DNS results.
- Updated relay details dialog UI to render the new sections and provide an explicit “show confirmed family” action on the map.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/src/dto/relay.ts | Extends RelayDetails DTO with familyId, confirmed family members, and verified/unverified hostnames; adjusts ASN typing. |
| frontend/src/components/dialogs/relay/RelayDetailsTable.tsx | Renders confirmed family members, “show family on map” action, and hostname lists; refactors row rendering. |
| frontend/src/components/dialogs/relay/RelayDetailsDialogSmall.tsx | Passes closeDialog into the details table for the new action button behavior. |
| frontend/src/components/dialogs/relay/RelayDetailsDialogLarge.tsx | Passes closeDialog into the details table for the new action button behavior. |
| frontend/src/components/buttons/SelectFamilyButton.tsx | Adds optional labeled button variant and refactors selection handler. |
| backend/src/test/kotlin/org/tormap/service/ReverseDnsLookupServiceTest.kt | Adds unit tests covering verified vs unverified hostname separation and no-PTR behavior. |
| backend/src/test/kotlin/org/tormap/service/RelayDetailsQueryServiceTest.kt | Adds unit tests ensuring relay details are enriched with confirmed family members and DNS results. |
| backend/src/test/kotlin/org/tormap/config/CacheConfigTest.kt | Extends cache config test to include the new reverse-DNS cache. |
| backend/src/main/kotlin/org/tormap/service/ReverseDnsLookupService.kt | Introduces reverse DNS resolver + lookup service with caching and result model. |
| backend/src/main/kotlin/org/tormap/service/RelayDetailsQueryService.kt | Adds query service to assemble enriched RelayDetailsDto (family + reverse DNS). |
| backend/src/main/kotlin/org/tormap/config/CacheConfig.kt | Adds Ehcache cache for reverse-DNS lookup results. |
| backend/src/main/kotlin/org/tormap/adapter/dto/RelayDetailsDto.kt | New DTO that includes confirmed family members and reverse-DNS hostname lists. |
| backend/src/main/kotlin/org/tormap/adapter/controller/RelayDetailsController.kt | Switches relay-details endpoint to return the enriched DTO via query service. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+126
to
+130
| const renderConfirmedFamilyMembers = (confirmedFamilyMembers?: { | ||
| id: number | ||
| fingerprint: string | ||
| nickname: string | ||
| }[]) => confirmedFamilyMembers && confirmedFamilyMembers.length > 0 ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26.
Summary
Verification
Notes