fix(ui5-search-field): Align hover/active background with design spec - #13951
Open
aleksandar-terziev wants to merge 1 commit into
Open
fix(ui5-search-field): Align hover/active background with design spec#13951aleksandar-terziev wants to merge 1 commit into
aleksandar-terziev wants to merge 1 commit into
Conversation
|
🚀 Deployed on https://pr-13951--ui5-webcomponents-preview.netlify.app |
nikoletavnv
reviewed
Aug 20, 2026
| @import "../base/DynamicPage-parameters.css"; | ||
| @import "../base/SearchField-parameters.css"; | ||
| @import "./SearchField-parameters.css"; | ||
| @import "../base/Search-parameters.css"; |
Contributor
There was a problem hiding this comment.
We can remove the duplicate import of @import "../base/Search-parameters.css";
niyap
reviewed
Aug 20, 2026
| --_ui5_search_separator_background: var(--sapShell_InteractiveBorderColor); | ||
| --_ui5-search-wrapper-hover-background: var(--sapField_Hover_BackgroundStyle); | ||
| --_ui5-search-wrapper-hover-background-color: var(--sapField_Hover_Background); | ||
| --_ui5-search-wrapper-hover-background-color: var(--sapShell_Hover_Background); |
Contributor
There was a problem hiding this comment.
I noticed that you have already created files for Horizon Light and Dark parameters. Please, adjust --_ui5-search-wrapper-hover-background-color in the same way as the one for "active" state. "none" as a value here and different value only in Horizon Light and Dark
aleksandar-terziev
force-pushed
the
ui5-search-field-theming
branch
from
August 20, 2026 12:14
43f8c8a to
170076c
Compare
aleksandar-terziev
requested a deployment
to
netlify-preview
August 20, 2026 12:14 — with 
GitHub Actions
In progress
GitHub Actions
In progress
aleksandar-terziev
force-pushed
the
ui5-search-field-theming
branch
from
August 20, 2026 12:21
170076c to
6c3dfef
Compare
aleksandar-terziev
requested a deployment
to
netlify-preview
August 20, 2026 12:21 — with
GitHub Actions
In progress
GitHub Actions
In progress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
sapShell_Hover_Backgroundand addsapShell_Active_Backgroundfor the active state