Skip to content

fix(ui5-search-field): Align hover/active background with design spec #13951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aleksandar-terziev wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ui5-search-field): Align hover/active background with design spec #13951

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/fiori/src/themes/SearchField.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,11 @@
background-color: var(--_ui5-search-wrapper-hover-background-color);
}

:host(:not([collapsed]):focus-within),
.ui5-shellbar-search-field-wrapper:focus-within {
background-color: var(--_ui5-search-wrapper-active-background-color);
}

:host([focused-inner-input]) .ui5-search-field-root {
outline: var(--_ui5_search_wrapper_outline);
border-radius: var(--_ui5_search_input_border_radius);
Expand Down
3 changes: 2 additions & 1 deletion packages/fiori/src/themes/base/SearchField-parameters.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@
--_ui5-search-wrapper-background: var(--sapShell_InteractiveBackground);
--_ui5_search_separator_background: var(--sapShell_InteractiveBorderColor);
--_ui5-search-wrapper-hover-background: var(--sapField_Hover_BackgroundStyle);
--_ui5-search-wrapper-hover-background-color: var(--sapField_Hover_Background);
--_ui5-search-wrapper-hover-background-color: none;
--_ui5-search-wrapper-active-background-color: none;
--_ui5-search-elements-hover-background: none;
--_ui5-search-elements-active-background: none;
--_ui5_search_input_scope_margin: 0 0.125rem 0 .5rem;
Expand Down
1 change: 0 additions & 1 deletion packages/fiori/src/themes/sap_fiori_3/SearchField-parameters.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
--_ui5-search-wrapper-background: var(--sapShellColor);
--_ui5_search_separator_background: none;
--_ui5-search-wrapper-hover-background: none;
--_ui5-search-wrapper-hover-background-color: none;
--_ui5_search_input_scope_margin: 0;
--_ui5-search_input_scope_hover_shadow: none;
--_ui5-search_input_scope_active_shadow: none;
Expand Down
1 change: 0 additions & 1 deletion packages/fiori/src/themes/sap_fiori_3_dark/SearchField-parameters.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
--_ui5-search-wrapper-background: var(--sapShellColor);
--_ui5_search_separator_background: none;
--_ui5-search-wrapper-hover-background: none;
--_ui5-search-wrapper-hover-background-color: none;
--_ui5_search_input_scope_margin: 0;
--_ui5-search_input_scope_hover_shadow: none;
--_ui5-search_input_scope_active_shadow: none;
Expand Down
1 change: 0 additions & 1 deletion packages/fiori/src/themes/sap_fiori_3_hcb/SearchField-parameters.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
--_ui5-search-wrapper-background: var(--sapShellColor);
--_ui5_search_separator_background: none;
--_ui5-search-wrapper-hover-background: none;
--_ui5-search-wrapper-hover-background-color: none;
--_ui5_search_input_scope_margin: 0;
--_ui5-search_input_scope_hover_shadow: none;
--_ui5-search_input_scope_active_shadow: none;
Expand Down
1 change: 0 additions & 1 deletion packages/fiori/src/themes/sap_fiori_3_hcw/SearchField-parameters.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
--_ui5-search-wrapper-background: var(--sapShellColor);
--_ui5_search_separator_background: none;
--_ui5-search-wrapper-hover-background: none;
--_ui5-search-wrapper-hover-background-color: none;
--_ui5_search_input_scope_margin: 0;
--_ui5-search_input_scope_hover_shadow: none;
--_ui5-search_input_scope_active_shadow: none;
Expand Down
6 changes: 6 additions & 0 deletions packages/fiori/src/themes/sap_horizon/SearchField-parameters.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
@import "../base/SearchField-parameters.css";

:host {
--_ui5-search-wrapper-hover-background-color: var(--sapShell_Hover_Background);
Comment thread
aleksandar-terziev marked this conversation as resolved.
--_ui5-search-wrapper-active-background-color: var(--sapShell_Active_Background);
}
3 changes: 1 addition & 2 deletions packages/fiori/src/themes/sap_horizon/parameters-bundle.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@
@import "./FlexibleColumnLayout-parameters.css";
@import "./MediaGallery-parameters.css";
@import "../base/DynamicPage-parameters.css";
@import "../base/SearchField-parameters.css";
@import "../base/Search-parameters.css";
@import "./SearchField-parameters.css";
@import "../base/Search-parameters.css";
Comment thread
aleksandar-terziev marked this conversation as resolved.
@import "./DynamicPageTitle-parameters.css";
@import "../base/DynamicPageHeader-parameters.css";
Expand Down
6 changes: 6 additions & 0 deletions packages/fiori/src/themes/sap_horizon_dark/SearchField-parameters.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
@import "../base/SearchField-parameters.css";

:host {
--_ui5-search-wrapper-hover-background-color: var(--sapShell_Hover_Background);
Comment thread
aleksandar-terziev marked this conversation as resolved.
--_ui5-search-wrapper-active-background-color: var(--sapShell_Active_Background);
}
2 changes: 1 addition & 1 deletion packages/fiori/src/themes/sap_horizon_dark/parameters-bundle.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
@import "./ProductSwitchItem-parameters.css";
@import "../base/ShellBar-parameters.css";
@import "./ShellBar-parameters.css";
@import "../base/SearchField-parameters.css";
@import "./SearchField-parameters.css";
@import "../base/Search-parameters.css";
@import "./TimelineItem-parameters.css";
@import "./SideNavigation-parameters.css";
Expand Down
1 change: 0 additions & 1 deletion packages/fiori/src/themes/sap_horizon_hcb/SearchField-parameters.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
--_ui5-search-wrapper-background: none;
--_ui5_search_separator_background: none;
--_ui5-search-wrapper-hover-background: none;
--_ui5-search-wrapper-hover-background-color: none;
--_ui5_search_input_scope_margin: 0;
--_ui5-search_input_scope_hover_shadow: none;
--_ui5-search_input_scope_active_shadow: none;
Expand Down
1 change: 0 additions & 1 deletion packages/fiori/src/themes/sap_horizon_hcw/SearchField-parameters.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
--_ui5-search-wrapper-background: none;
--_ui5_search_separator_background: none;
--_ui5-search-wrapper-hover-background: none;
--_ui5-search-wrapper-hover-background-color: none;
--_ui5_search_input_scope_margin: 0;
--_ui5-search_input_scope_hover_shadow: none;
--_ui5-search_input_scope_active_shadow: none;
Expand Down
Loading