refactor(cache): make the size provider a field, since that is what it is

[cosmin-staicu]

MemoryCacheSetter.SizeProvider was a get-only private property holding a value resolved once from the options:

private ICacheEntrySizeProvider SizeProvider { get; } = memoryCacheOptions.SizeProvider ?? new DefaultCacheEntrySizeProvider();

No computation, no interception, nothing a property buys over a field. It is now _sizeProvider, declared with the other fields — which also keeps it out of the property block that the ordering rules group together.

Came out of counting property accessibilities across src while sizing up the StyleCop ordering rules: 398 properties, of which exactly four are private. The other three earn it — RedisStreamHealthMaintainer.Database, RedisStreamSubjectWriter.ContinueLoop and RedisConnector.ConnectionMultiplexer all compute on every read, which is what a private property is for. This was the only one holding state.

IMemoryCacheOptions.SizeProvider, the public option it reads from, is untouched.

Build clean, full suite green: 1704 on net10, 1683 on net8.

🤖 Generated with Claude Code

https://claude.ai/code/session_01NsPw6MZHPGmpbo6WDuLzF1

[Copilot]

🟢 Approval recommended

The change is a behavior-preserving refactor with a straightforward substitution and no observable functional impact.

Pull request overview

This PR refactors MemoryCacheSetter to store the resolved ICacheEntrySizeProvider as a private readonly field instead of a get-only private property, aligning the implementation with its actual behavior (stateful, resolved once) and avoiding unnecessary “property” semantics.

Changes:

• Replace private ICacheEntrySizeProvider SizeProvider { get; } = ... with private readonly ICacheEntrySizeProvider _sizeProvider = ....
• Update the SetSize(...) call site to use _sizeProvider.

File summaries

File	Description
src/UiPath.Caching/MemoryCacheSetter.cs	Convert size-provider from private get-only property to private readonly field and update usage accordingly.

Review details

• Files reviewed: 1/1 changed files
• Comments generated: 0
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud