Skip to content

refactor(cache): make the size provider a field, since that is what it is #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cosmin-staicu wants to merge 1 commit into from
+2 −3
Closed

refactor(cache): make the size provider a field, since that is what it is #175

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/UiPath.Caching/MemoryCacheSetter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,13 @@ internal abstract class MemoryCacheSetter(
)
{
private readonly KeyMasker _masker = masker ?? KeyMasker.Off;
private readonly ICacheEntrySizeProvider _sizeProvider = memoryCacheOptions.SizeProvider ?? new DefaultCacheEntrySizeProvider();

private const string EventRefreshMetadataFailed = "Caching." + nameof(MemoryCacheSetter) + "." + nameof(RefreshMetadata) + ".Failed";
private const string PropCacheKey = "CacheKey";
private const string PropTopicKey = "TopicKey";
private const string PropTransportId = "TransportId";

private ICacheEntrySizeProvider SizeProvider { get; } = memoryCacheOptions.SizeProvider ?? new DefaultCacheEntrySizeProvider();

protected TimeProvider Clock { get; } = clock;

public bool Set(ICacheEntryOptions options, ICacheEntry item, Type entryType, TimeSpan? maxExpiration)
Expand All @@ -43,7 +42,7 @@ public bool Set(ICacheEntryOptions options, ICacheEntry item, Type entryType, Ti
memOptions.RegisterPostEvictionCallback(PostEviction, token);
if(memoryCacheOptions.SizeLimit.HasValue)
{
memOptions.SetSize(SizeProvider.GetSize(item));
memOptions.SetSize(_sizeProvider.GetSize(item));
}
memoryCache.Set(options.CacheKey, item, memOptions);
return true;
Expand Down