Skip to content

FIX: Enforce a minimum window size on the Input Debugger window [UUM-137119] - #2461

Merged
Pauliusd01 merged 1 commit into
developfrom
fix/uum-137119-inputdebuggerwindow-minsize
Aug 4, 2026
Merged

FIX: Enforce a minimum window size on the Input Debugger window [UUM-137119]#2461
Pauliusd01 merged 1 commit into
developfrom
fix/uum-137119-inputdebuggerwindow-minsize

Conversation

@Pauliusd01

Copy link
Copy Markdown
Collaborator

Description

Note

This pull request was generated automatically. Please review carefully before merging.

InputDebuggerWindow.OnEnable() assigned only titleContent and never set a minimum window size, so the Input Debugger (Window > Analysis > Input Debugger) could be resized arbitrarily small — small enough that its toolbar and the device/action/layout tree view were no longer usably visible.

OnEnable() now also assigns minSize = new Vector2(270, 300), the same minimum the sibling InputDeviceDebuggerWindow already applies. Setting it in OnEnable rather than in CreateOrShow() means the minimum is re-applied after domain reloads and when a docked or persisted window is restored from the editor layout, not only when the window is first opened from the menu item.

Testing status & QA

  • No automated test added — the change sets EditorWindow.minSize through the editor window lifecycle and there is no existing test fixture exercising the Input Debugger windows.
  • Manual QA: open Window > Analysis > Input Debugger and confirm the window can no longer be resized small enough to hide its toolbar and tree view, per the repro in https://jira.unity3d.com/browse/UUM-137119.

Overall Product Risks

  • Complexity: low
  • Halo Effect: low (single additive statement confined to one editor-only window's OnEnable; no public API surface touched)
  • Risk rating: 2/5 — Single additive statement setting an inherited EditorWindow property in a private editor-only window, mirroring three sibling windows; no test exercises it and the type carries inert serialization callbacks.

Comments to reviewers

N/A

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

…137119]

The Input Debugger window never assigned a minimum size, so it could be resized arbitrarily small until its toolbar and device/action/layout tree view were no longer usably visible.

InputDebuggerWindow.OnEnable() previously set only titleContent; it now also assigns minSize = new Vector2(270, 300), mirroring the sibling InputDeviceDebuggerWindow. Setting the minimum in OnEnable rather than CreateOrShow() re-applies it after domain reloads and when a persisted or docked window is restored from the editor layout, not only when the window is first opened from the menu.

Jira: https://jira.unity3d.com/browse/UUM-137119
@Pauliusd01 Pauliusd01 self-assigned this Aug 4, 2026
@Pauliusd01

Copy link
Copy Markdown
Collaborator Author

Min size looks like this:

image

@Pauliusd01
Pauliusd01 marked this pull request as ready for review August 4, 2026 11:05
@Pauliusd01
Pauliusd01 requested a review from ritamerkl August 4, 2026 11:05

@u-pr u-pr Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Harness Review

Ship it

Small, self-contained editor-only fix that matches the existing debugger-window sizing pattern; I didn't find a concrete issue worth flagging.

Reviewed commit ae99d79

🤖 Helpful? 👍/👎

@Pauliusd01
Pauliusd01 merged commit a8bc230 into develop Aug 4, 2026
18 of 109 checks passed
@Pauliusd01
Pauliusd01 deleted the fix/uum-137119-inputdebuggerwindow-minsize branch August 4, 2026 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants