Skip to content

List Tables: Prevent Filter button submission and show admin notice when no filters are selected - #12754

Open
himanshupathak95 wants to merge 3 commits into
WordPress:trunkfrom
himanshupathak95:fix/31634
Open

List Tables: Prevent Filter button submission and show admin notice when no filters are selected#12754
himanshupathak95 wants to merge 3 commits into
WordPress:trunkfrom
himanshupathak95:fix/31634

Conversation

@himanshupathak95

@himanshupathak95 himanshupathak95 commented Jul 29, 2026

Copy link
Copy Markdown

Trac ticket: https://core.trac.wordpress.org/ticket/31634

Adds client-side validation to the Filter button in WP_List_Table admin screens (Posts, Comments, Media, Links, Sites). When the Filter button is clicked with no meaningful filter criteria selected, the form submission is intercepted. A dismissible admin error notice reading "Please select a filter to apply." is injected at the top of the page, and wp.a11y.speak() announces it for screen reader users.

The two new button name identifiers (filter_action, post-query-submit) are registered alongside the existing bulk-action observer IDs in script-loader.php and remain filterable via the bulk_action_observer_ids filter for third-party extensibility.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@himanshupathak95
himanshupathak95 marked this pull request as ready for review August 10, 2026 10:44
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props abcd95.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant