Skip to content

List Tables: Prevent Filter button submission and show admin notice when no filters are selected #12754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
himanshupathak95 wants to merge 3 commits into
base: trunk
Choose a base branch
from
Open

List Tables: Prevent Filter button submission and show admin notice when no filters are selected #12754

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ecc42d0
prevent submission of admin filter forms when no filter criteria are …
himanshupathak95 Jul 29, 2026
65e6296
prevent form submission and display error notice when applying empty …
himanshupathak95 Jul 29, 2026
662e20f
add filter_action and post-query-submit keys to bulk_action_observer_…
himanshupathak95 Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 47 additions & 1 deletion src/js/_enqueues/admin/common.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1330,7 +1330,53 @@ $( function() {
'bulk_action' : window.bulkActionObserverIds.bulk_action,
'changeit' : window.bulkActionObserverIds.changeit
};
if ( ! Object.keys( bulkFieldRelations ).includes( submitterName ) ) {

var filterButtonNames = [
window.bulkActionObserverIds.filter_action,
window.bulkActionObserverIds['post-query-submit']
];

if ( ! Object.keys( bulkFieldRelations ).includes( submitterName ) && ! filterButtonNames.includes( submitterName ) ) {
return;
}

if ( filterButtonNames.includes( submitterName ) ) {
var filterDropdowns = form.querySelectorAll( '.actions select' );
var isFilterActionValid = false;
var urlParams = new URLSearchParams( window.location.search );

for ( var i = 0; i < filterDropdowns.length; i++ ) {
var select = filterDropdowns[ i ];
if ( select.name === 'action' || select.name === 'action2' ) {
continue;
}
if ( select.value !== '0' && select.value !== '' && select.value !== '-1' ) {
isFilterActionValid = true;
break;
}
if ( urlParams.has( select.name ) ) {
isFilterActionValid = true;
break;
}
}

if ( isFilterActionValid ) {
return;
}

event.preventDefault();
event.stopPropagation();
$( 'html, body' ).animate( { scrollTop: 0 } );

var filterErrorMessage = __( 'Please select a filter to apply.' );
addAdminNotice( {
id: 'no-filter-selected',
type: 'error',
message: filterErrorMessage,
dismissible: true,
} );

wp.a11y.speak( filterErrorMessage );
return;
}

Expand Down
13 changes: 9 additions & 4 deletions src/wp-includes/script-loader.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -767,8 +767,10 @@ function wp_default_scripts( $scripts ) {
$scripts->set_translations( 'common' );

$bulk_action_observer_ids = array(
'bulk_action' => 'action',
'changeit' => 'new_role',
'bulk_action' => 'action',
'changeit' => 'new_role',
'filter_action' => 'filter_action',
'post-query-submit' => 'post-query-submit',
);
did_action( 'init' ) && $scripts->localize(
'common',
Expand All @@ -777,12 +779,15 @@ function wp_default_scripts( $scripts ) {
* Filters the array of field name attributes for bulk actions.
*
* @since 6.8.1
* @since 7.2.0 Added 'filter_action' and 'post-query-submit' keys.
*
* @param array $bulk_action_observer_ids {
* An array of field name attributes for bulk actions.
*
* @type string $bulk_action The bulk action field name. Default 'action'.
* @type string $changeit The new role field name. Default 'new_role'.
* @type string $bulk_action The bulk action field name. Default 'action'.
* @type string $changeit The new role field name. Default 'new_role'.
* @type string $filter_action The list table Filter button field name. Default 'filter_action'.
* @type string $post-query-submit The media library Filter button field name. Default 'post-query-submit'.
* }
*/
apply_filters( 'bulk_action_observer_ids', $bulk_action_observer_ids )
Expand Down
Loading