Recent messages: fixes, revisions, rewrites - #187
Merged
Conversation
- Only write one variant of first remains hint - Revert Woodfall Map message's color values
- Favor GetHint over GetName in dialogue - Reword messages for grammar/brevity/consistency (+ added ones) - Add second prize mention before second set of beaver races - Bring some messages closer to vanilla (all languages) - Revise French - Add/draft more languages to some hints - Add "?" on hint languages that (may) need native speaker check - Draft keyring get messages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to make the script more consistent and grammatically correct, and improve some translations (sometimes at the cost of lacking others, sorry)
Also adds a new hint before second set of beaver races, fixes small code oversights, etc.
Known remaining nits (current system would make replacements too hardcodey):