Skip to content

fix(providers): preserve custom model descriptors and restore Copilot startup - #272

Merged
aaditagrawal merged 5 commits into
mainfrom
fix/alignment-provider-model-settings
Sep 5, 2026
Merged

fix(providers): preserve custom model descriptors and restore Copilot startup#272
aaditagrawal merged 5 commits into
mainfrom
fix/alignment-provider-model-settings

Conversation

@aaditagrawal

@aaditagrawal aaditagrawal commented Sep 5, 2026

Copy link
Copy Markdown
Owner

The upstream model editor can write named/custom-option descriptors, but fork-only provider schemas accepted only strings. Saving those settings could make an entire instance unavailable. Accepts the shared backward-compatible model setting across all fork schemas, Copilot driver settings, and ACP config types; preserves labels/options and legacy strings.

Also repairs two live Copilot startup failures: a narrow patch corrects extensionless native ESM imports in the pinned SDK, and a shared resolver stops passing the default command basename as an SDK filesystem path. Applies to health, sessions, model discovery, and usage. No dependency version upgrade.

Validation: regression matrix covers all 16 built-in driver schemas and legacy settings/patches; 147 focused compatibility tests and 11 final SDK/path tests passed. Native Node24 SDK starts/stops without a model turn; two previously skipped adapter tests now run. Full workspace check/typecheck passed. Integrated UI saves a named Copilot model, retains it through restart, and reaches correct signed-out provider health without schema/import failures. Full server run passed 4,073 tests before the final narrow CLI-path change; its affected suites passed afterward.

@aaditagrawal aaditagrawal changed the title fix(providers): accept structured custom models across fork drivers fix(providers): preserve custom model descriptors and restore Copilot startup Sep 5, 2026
…p' into fix/alignment-provider-model-settings

Co-authored-by: aaditagrawal <aaditagrawal@users.noreply.github.com>
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M 30-99 effective changed lines (test files excluded in mixed PRs). labels Sep 5, 2026
@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ No successful main baseline artifact is available yet. This run establishes the initial measurement.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 13.5 KiB 15.1 KiB
Codex Thread snapshot wire 7.0 KiB 7.3 KiB
Codex Live turn WebSocket wire 6.5 KiB 7.8 KiB
Codex Live turn WebSocket decoded 57.0 KiB 66.4 KiB
Codex Live turn messages 8 21
Claude Total thread wire 13.5 KiB 15.1 KiB
Claude Thread snapshot wire 7.0 KiB 7.3 KiB
Claude Live turn WebSocket wire 6.5 KiB 7.8 KiB
Claude Live turn WebSocket decoded 57.8 KiB 66.4 KiB
Claude Live turn messages 8 21

Baseline: unavailable · PR result: 5086d4b · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 113.9 KiB
  • Claude decoded thread snapshot: 114.6 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

…p' into fix/alignment-provider-model-settings

Co-authored-by: aaditagrawal <aaditagrawal@users.noreply.github.com>

aaditagrawal commented Sep 5, 2026

Copy link
Copy Markdown
Owner Author

Merge activity

@aaditagrawal
aaditagrawal changed the base branch from refactor/alignment-client-cleanup to main September 5, 2026 07:48
@aaditagrawal
aaditagrawal merged commit 4cbb3c9 into main Sep 5, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 effective changed lines (test files excluded in mixed PRs). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants