fix(providers): preserve custom model descriptors and restore Copilot startup - #272
Merged
Merged
Conversation
This was referenced Sep 5, 2026
Owner
Author
This was referenced Sep 5, 2026
…p' into fix/alignment-provider-model-settings Co-authored-by: aaditagrawal <aaditagrawal@users.noreply.github.com>
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: unavailable · PR result: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
…p' into fix/alignment-provider-model-settings Co-authored-by: aaditagrawal <aaditagrawal@users.noreply.github.com>
Owner
Author
Merge activity
|
aaditagrawal
changed the base branch from
refactor/alignment-client-cleanup
to
main
September 5, 2026 07:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The upstream model editor can write named/custom-option descriptors, but fork-only provider schemas accepted only strings. Saving those settings could make an entire instance unavailable. Accepts the shared backward-compatible model setting across all fork schemas, Copilot driver settings, and ACP config types; preserves labels/options and legacy strings.
Also repairs two live Copilot startup failures: a narrow patch corrects extensionless native ESM imports in the pinned SDK, and a shared resolver stops passing the default command basename as an SDK filesystem path. Applies to health, sessions, model discovery, and usage. No dependency version upgrade.
Validation: regression matrix covers all 16 built-in driver schemas and legacy settings/patches; 147 focused compatibility tests and 11 final SDK/path tests passed. Native Node24 SDK starts/stops without a model turn; two previously skipped adapter tests now run. Full workspace check/typecheck passed. Integrated UI saves a named Copilot model, retains it through restart, and reaches correct signed-out provider health without schema/import failures. Full server run passed 4,073 tests before the final narrow CLI-path change; its affected suites passed afterward.