Put the abap2UI5 logo in the tab - #52
Merged
Merged
Conversation
The page shipped `<link rel="icon" href="data:,">` - a deliberately empty icon, which buys a browser that does not ask for a favicon and costs the page its face. In a row of tabs it was a blank sheet beside the documentation, which has carried the logo all along, so the two did not read as one project. `favicon.ico` is that same mark. It is the artwork of `docs/public/favicon.ico` in abap2UI5/docs, rescaled rather than copied: that file is a single 256px frame stored uncompressed, 265 KB, twenty times the weight of this whole page for something a browser draws at 16px. This one carries 16/32/48/64/128 as PNG frames in 16 KB. The source is 256x251, not square, so the frames are fitted and padded - a single frame is what a browser squashes. deploy-web asserts it like the other static files: an icon that silently stopped being uploaded is exactly the kind of thing nobody notices. Identical in samples, samples-controls and samples-stack, and documented in web/README.md of each. Claude-Session: https://claude.ai/code/session_01XEQ6sewT1hd5KvrCKZrNEo Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The page shipped
<link rel="icon" href="data:,">— a deliberately empty icon, which buys a browser that does not ask for a favicon and costs the page its face. In a row of tabs it was a blank sheet beside the documentation, which has carried the logo all along, so the two did not read as one project.web/favicon.icois that same mark. It is the artwork ofdocs/public/favicon.icoin abap2UI5/docs, rescaled rather than copied: that file is a single 256 px frame stored uncompressed, 265 KB, twenty times the weight of this whole page for something a browser draws at 16 px. This one carries 16/32/48/64/128 px as PNG frames in 15.8 KB. The source is 256 × 251, not square, so the frames are fitted and padded — a single frame is what a browser squashes.deploy-webasserts the icon like the other static files before the upload: an icon that silently stopped being shipped is exactly the kind of thing nobody notices.Identical in samples, samples-controls and samples-stack, and documented under The icon in the tab in
web/README.mdof each.Checked: the ICO re-parses to five frames at the offsets its directory claims, Chromium decodes it (picks the 128 px frame for a 128 px box), and
npm run check:family-navandnpm run check:webstay green.Generated by Claude Code