Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/deploy-web.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -60,11 +60,11 @@ jobs:
# The gate this pipeline needs now that there is nothing here that can
# fail to build: a page whose data file is missing deploys exactly like a
# working one — it just says "the catalogue could not be loaded" to every
# visitor. Assert the four files and a non-trivial index before uploading.
# visitor. Assert the five files and a non-trivial index before uploading.
- name: Check the artefact is complete
run: |
cd web
for f in index.html stack.css stack.js apps.json; do
for f in index.html stack.css stack.js apps.json favicon.ico; do
test -s "$f" || { echo "deploy-web: $f is missing or empty"; exit 1; }
done
node -e '
Expand Down
17 changes: 17 additions & 0 deletions web/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ system actually runs. Published by the
web/index.html the page — one file, no framework
web/stack.css one stylesheet, light and dark off one set of custom properties
web/stack.js filtering and drawing — plain ES2020, no dependencies
web/favicon.ico the abap2UI5 logo in the tab (see below)
web/apps.json generated, NOT committed (see below)
```

Expand Down Expand Up @@ -49,6 +50,22 @@ keeps every package at or below it. The counts are in the labels, so what an
older system costs is visible before the click. Filters live in the URL, so a
search is linkable.

## The icon in the tab

`favicon.ico` is the abap2UI5 logo — the same mark
[the documentation](https://abap2ui5.github.io/docs/) puts in the tab, so the
four pages of the project read as one project in a row of browser tabs rather
than as three anonymous ones beside it.

It is the artwork of `docs/public/favicon.ico` in
[abap2UI5/docs](https://github.com/abap2UI5/docs), rescaled: that file is one
256 px frame stored uncompressed, 265 KB, which is twenty times this whole page
for something a browser draws at 16 px. This one carries 16/32/48/64/128 px as
PNG frames in ~16 KB, so every size the browser asks for is a frame that was
drawn for it and none of them is squashed — the source is 256 × 251, not
square, so a single frame is what a browser distorts. Identical in all three
sample repositories.

## The bar at the top is shared, and so is the strip at the bottom

Three repositories publish three pages that answer three different questions,
Expand Down
Binary file added web/favicon.ico
Binary file not shown.
6 changes: 5 additions & 1 deletion web/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,11 @@
<meta name="viewport" content="width=device-width, initial-scale=1">
<title>abap2UI5 and your stack · samples-stack</title>
<meta name="description" content="Every abap2UI5 sample that plays together with your stack — OData, Smart Controls, RAP, business events, stateful sessions, WebSockets, MIME, the Fiori Launchpad. Search them by technology and by the release your system runs, and see what each one needs before you install anything.">
<link rel="icon" href="data:,">
<!-- The abap2UI5 logo, the same mark the documentation puts in the tab.
One .ico carrying 16/32/48/64/128 px, so the browser picks a size
instead of squashing one. See web/README.md for where it comes from. -->
<link rel="icon" href="favicon.ico" sizes="16x16 32x32 48x48 64x64 128x128">
<link rel="apple-touch-icon" href="favicon.ico">
<link rel="stylesheet" href="stack.css">
</head>
<body>
Expand Down