feat(acl): add ACL whitelist management API for contract integration permissions (#966) - #974
Merged
Conversation
…permissions (accesslayerorg#966) Expose admin CRUD endpoints for the on-chain ACL controlling which external contracts may interact with the platform, gated by 2-of-3 admin multisig authorization. - GET /admin/acl paginated list of whitelisted contracts with their permitted function sets - POST /admin/acl add a contract + function list, validated (Soroban contract address format, function name rules) before submitting on-chain - DELETE /admin/acl/:id remove a contract from the whitelist - GET /admin/acl/history paginated add/remove event log with actor, signers, and timestamp Mutations reuse the existing 2-of-3 admin multisig pattern from key deprecation (verifyDeprecationSignatures/parseMultisigAdminWallets): each add/remove requires Ed25519 signatures from distinct configured admin wallets over a canonical message scoped to the action, contract address, and function set, preventing replay across actions. History is stored in a separate append-only AclEvent table so it survives whitelist removal. Adds: - prisma/schema/acl.prisma (AclWhitelist, AclEvent models) + migration - src/modules/acl/{acl.schemas,acl.service,acl.controllers,acl.routes}.ts - src/modules/acl/acl.integration.test.ts Mounts aclRouter at /admin/acl in admin.routes.ts. Closes accesslayerorg#966
|
@KingDavid9999 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose admin CRUD endpoints for the on-chain ACL controlling which
external contracts may interact with the platform, gated by 2-of-3
admin multisig authorization.
with their permitted function sets
(Soroban contract address format, function
name rules) before submitting on-chain
actor, signers, and timestamp
Mutations reuse the existing 2-of-3 admin multisig pattern from key
deprecation (verifyDeprecationSignatures/parseMultisigAdminWallets):
each add/remove requires Ed25519 signatures from distinct configured
admin wallets over a canonical message scoped to the action, contract
address, and function set, preventing replay across actions.
History is stored in a separate append-only AclEvent table so it
survives whitelist removal.
Adds:
Mounts aclRouter at /admin/acl in admin.routes.ts.
Closes #966