fix(tools): expose remember to local-model agents - #111
Merged
Conversation
minimal_tools() (and therefore dynamic_tools(), the toolset every litellm/ollama/vllm-backed agent variant actually gets) never included remember_tool, despite build_permission() allowing it unconditionally. refactor_dynamic_tools() had the same gap against its own refactor_permission(), which explicitly lists "remember". A local-model agent had no way to propose a memory candidate at all — confirmed live, the model correctly reported it had no such tool and declined to fabricate a call rather than hallucinate one. Adds remember_tool.tool() to both lists. It's a single [net, io, proc] tool that appends one JSONL line (candidates.lex), cheap enough for the curated core rather than needing load_toolset gating. Fixes #110
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #110
Test plan