Fix #20763: Match Scheduler.answerCard with upstream Anki#21163
Open
vivek41-glitch wants to merge 1 commit into
Open
Fix #20763: Match Scheduler.answerCard with upstream Anki#21163vivek41-glitch wants to merge 1 commit into
vivek41-glitch wants to merge 1 commit into
Conversation
Contributor
Author
|
This PR fixes #20763 by replacing queuedCards.cardsList.first() with col.backend.getSchedulingStates(card.id) to match upstream Anki. |
This comment was marked as resolved.
This comment was marked as resolved.
david-allison
added
Needs Author Reply
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
Author
|
thanks @DoomsCoder for guiding , and @david-allison all test passed including kotlin issue , now ready for final review. |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
david-allison
added
Needs Second Approval
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20763
Replace queuedCards.cardsList.first() with col.backend.getSchedulingStates(card.id) to match upstream Python implementation.