Repository navigation
GH-55287: [C++][Parquet] Write fixed-size lists faster - #55251
Draft
MashrafeeAryan wants to merge 6 commits into
Draft
MashrafeeAryan wants to merge 6 commits into
MashrafeeAryan wants to merge 6 commits into
Conversation
Compare writing fixed-size lists of floats with writing the same values as a flat column. Test six list sizes with V1 and V2 pages.
Add an encoder helper that writes the same value many times. Check that it produces the same bytes as writing values one at a time.
Write a repeated definition level without first building an array. Add tests for matching bytes and invalid inputs.
Use the fixed list size to write the start and continuation markers. Check that the encoded bytes match the existing encoder.
Skip temporary marker arrays for supported fixed-size lists without nulls. Keep the existing path for other inputs. Test matching output, lower memory use, and fallback cases.
|
|
github-actions
Bot
added
Component: Parquet
Component: C++
awaiting review
|
|
MashrafeeAryan
changed the title
|
|
|
|
2 similar comments
|
|
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
While saving fixed-size lists to a Parquet file, it does extra work and takes time. Each value in the list gets a definition level and a repetition level. However, for a list of size n with no nulls, those levels are fully predictable. So we avoid creating markers for definition levels and repetition levels to save time writing fixed-size lists.
What changes are included in this PR?
Are these changes tested?
Yes all of these are tested
Are there any user-facing changes?
Supports fixed-size lists write faster and use less temporary memory.
Was AI used for this PR?
I haves used Codex and Caludef or reviewing and debugging.
PR code and description written by:
Reviewed before submission by:
Related Issue: rok#60