[LucaCappelletti94]

DROP FOREIGN TABLE IF EXISTS ft, other CASCADE and COMMENT ON FOREIGN TABLE ft IS 'remote orders' failed at FOREIGN. Both now parse, with ObjectType::ForeignTable and CommentObject::ForeignTable of their own, because PostgreSQL refuses DROP TABLE and COMMENT ON TABLE on a foreign table.

https://www.postgresql.org/docs/current/sql-dropforeigntable.html
https://www.postgresql.org/docs/current/sql-comment.html

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.42%. Comparing base (5989f9c) to head (248056b).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2746      +/-   ##
==========================================
+ Coverage   82.41%   82.42%   +0.01%     
==========================================
  Files          42       42              
  Lines       35361    35371      +10     
  Branches    35361    35371      +10     
==========================================
+ Hits        29143    29156      +13     
+ Misses       2681     2678       -3     
  Partials     3537     3537              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[s5dsn-eqee]

PostgreSQL DROP FOREIGN TABLE synopsis, DROP FOREIGN TABLE [ IF EXISTS ] name [, ...] [ CASCADE | RESTRICT ] (no TEMPORARY, PURGE or ON):

https://www.postgresql.org/docs/current/sql-dropforeigntable.html

    if object_type == ObjectType::ForeignTable && (temporary || purge || table.is_some()) {
          return parser_err!(
              "Cannot specify TEMPORARY, PURGE, or ON in DROP FOREIGN TABLE",
              loc
          );
      }

and red tests

 #[test]
  fn parse_drop_foreign_table_rejects_modifiers() {
      for sql in [
          "DROP TEMPORARY FOREIGN TABLE ft",
          "DROP FOREIGN TABLE ft PURGE",
          "DROP FOREIGN TABLE ft ON t",
      ] {
          assert!(all_dialects().parse_sql_statements(sql).is_err(), "{sql}");
      }
  }

[s5dsn-eqee]

LGTM!

[LucaCappelletti94]

Thanks @s5dsn-eqee for the review, I will be merging this now.

cc @alamb