Skip to content

stm32: Detach GPIO IRQ callbacks upon clearing "setevent" #19520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Javinator9889 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

stm32: Detach GPIO IRQ callbacks upon clearing "setevent" #19520

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
577bf5a
stm32: Detach GPIO IRQ callbacks upon clearing "setevent"
Javinator9889 Jul 24, 2026
b54cca3
Review: Address @raiden00pl comments
Javinator9889 Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions arch/arm/src/common/stm32/stm32_exti_gpio_m0_v1.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,7 @@ int stm32_gpiosetevent(uint32_t pinset, bool risingedge, bool fallingedge,
xcpt_t handler;
int nshared;
int i;
int ret;

/* Select the interrupt handler for this EXTI pin */

Expand Down Expand Up @@ -274,6 +275,16 @@ int stm32_gpiosetevent(uint32_t pinset, bool risingedge, bool fallingedge,

if (i == nshared)
{
/* remove any leftover callback */
Comment thread
xiaoxiang781216 marked this conversation as resolved.

ret = irq_detach(irq);
if (ret < 0)
{
return ret;
}

/* disable the interrupt */

up_disable_irq(irq);
}
}
Expand Down
11 changes: 11 additions & 0 deletions arch/arm/src/common/stm32/stm32_exti_gpio_m3m4_v1v2.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,7 @@ int stm32_gpiosetevent(uint32_t pinset, bool risingedge, bool fallingedge,
xcpt_t handler;
int nshared;
int i;
int ret;

/* Select the interrupt handler for this EXTI pin */

Expand Down Expand Up @@ -333,6 +334,16 @@ int stm32_gpiosetevent(uint32_t pinset, bool risingedge, bool fallingedge,

if (i == nshared)
{
/* remove any leftover callback */

ret = irq_detach(irq);
if (ret < 0)
{
return ret;
}

/* disable the interrupt */

up_disable_irq(irq);
}
}
Expand Down
11 changes: 11 additions & 0 deletions arch/arm/src/stm32f7/stm32_exti_gpio.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,7 @@ int stm32_gpiosetevent(uint32_t pinset, bool risingedge, bool fallingedge,
xcpt_t handler;
int nshared;
int i;
int ret;

/* Select the interrupt handler for this EXTI pin */

Expand Down Expand Up @@ -340,6 +341,16 @@ int stm32_gpiosetevent(uint32_t pinset, bool risingedge, bool fallingedge,

if (i == nshared)
{
/* remove any leftover callback */

ret = irq_detach(irq);
if (ret < 0)
{
return ret;
}

/* disable the interrupt */

up_disable_irq(irq);
}
}
Expand Down
11 changes: 11 additions & 0 deletions arch/arm/src/stm32h7/stm32_exti_gpio.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,7 @@ int stm32_gpiosetevent(uint32_t pinset, bool risingedge, bool fallingedge,
xcpt_t handler;
int nshared;
int i;
int ret;

/* Select the interrupt handler for this EXTI pin */

Expand Down Expand Up @@ -342,6 +343,16 @@ int stm32_gpiosetevent(uint32_t pinset, bool risingedge, bool fallingedge,

if (i == nshared)
{
/* remove any leftover callback */

ret = irq_detach(irq);
if (ret < 0)
{
return ret;
}

/* disable the interrupt */

up_disable_irq(irq);
}
}
Expand Down
11 changes: 11 additions & 0 deletions arch/arm/src/stm32l4/stm32l4_exti_gpio.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,7 @@ int stm32_gpiosetevent(uint32_t pinset, bool risingedge, bool fallingedge,
xcpt_t handler;
int nshared;
int i;
int ret;

/* Select the interrupt handler for this EXTI pin */

Expand Down Expand Up @@ -336,6 +337,16 @@ int stm32_gpiosetevent(uint32_t pinset, bool risingedge, bool fallingedge,

if (i == nshared)
{
/* remove any leftover callback */

ret = irq_detach(irq);
if (ret < 0)
{
return ret;
}

/* disable the interrupt */

up_disable_irq(irq);
}
}
Expand Down
11 changes: 11 additions & 0 deletions arch/arm/src/stm32l5/stm32l5_exti_gpio.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@ int stm32_gpiosetevent(uint32_t pinset, bool risingedge, bool fallingedge,
uint32_t pin = pinset & GPIO_PIN_MASK;
uint32_t exti = 1 << pin;
int irq = STM32_IRQ_EXTI0 + pin;
int ret;

g_gpio_handlers[pin].callback = func;
g_gpio_handlers[pin].arg = arg;
Expand All @@ -139,6 +140,16 @@ int stm32_gpiosetevent(uint32_t pinset, bool risingedge, bool fallingedge,
}
else
{
/* remove any leftover callback */

ret = irq_detach(irq);
if (ret < 0)
{
return ret;
}

/* disable the interrupt */

up_disable_irq(irq);
}

Expand Down
11 changes: 11 additions & 0 deletions arch/arm/src/stm32u5/stm32_exti_gpio.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@ int stm32_gpiosetevent(uint32_t pinset, bool risingedge, bool fallingedge,
uint32_t pin = pinset & GPIO_PIN_MASK;
uint32_t exti = 1 << pin;
int irq = STM32_IRQ_EXTI0 + pin;
int ret;

g_gpio_handlers[pin].callback = func;
g_gpio_handlers[pin].arg = arg;
Expand All @@ -139,6 +140,16 @@ int stm32_gpiosetevent(uint32_t pinset, bool risingedge, bool fallingedge,
}
else
{
/* remove any leftover callback */

ret = irq_detach(irq);
if (ret < 0)
{
return ret;
}

/* disable the interrupt */

up_disable_irq(irq);
}

Expand Down
11 changes: 11 additions & 0 deletions arch/arm/src/stm32wb/stm32wb_exti_gpio.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,7 @@ int stm32_gpiosetevent(uint32_t pinset, bool risingedge, bool fallingedge,
xcpt_t handler;
int nshared;
int i;
int ret;

/* Select the interrupt handler for this EXTI pin */

Expand Down Expand Up @@ -334,6 +335,16 @@ int stm32_gpiosetevent(uint32_t pinset, bool risingedge, bool fallingedge,

if (i == nshared)
{
/* remove any leftover callback */

ret = irq_detach(irq);
if (ret < 0)
{
return ret;
}

/* disable the interrupt */

up_disable_irq(irq);
}
}
Expand Down
11 changes: 11 additions & 0 deletions arch/arm/src/stm32wl5/stm32wl5_exti_gpio.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,7 @@ int stm32_gpiosetevent(uint32_t pinset, bool risingedge, bool fallingedge,
xcpt_t handler;
int nshared;
int i;
int ret;

/* Select the interrupt handler for this EXTI pin */

Expand Down Expand Up @@ -336,6 +337,16 @@ int stm32_gpiosetevent(uint32_t pinset, bool risingedge, bool fallingedge,

if (i == nshared)
{
/* remove any leftover callback */

ret = irq_detach(irq);
if (ret < 0)
{
return ret;
}

/* disable the interrupt */

up_disable_irq(irq);
}
}
Expand Down
Loading