boards/sim: add ROMFS passwd and crypto deps for NSH console login - #19576
Open
Abhishekmishra2808 wants to merge 2 commits into
Open
boards/sim: add ROMFS passwd and crypto deps for NSH console login#19576Abhishekmishra2808 wants to merge 2 commits into
Abhishekmishra2808 wants to merge 2 commits into
Conversation
Enable BOARD_ETC_ROMFS_PASSWD_ENABLE and software cryptodev options on all sim configs with CONFIG_NSH_CONSOLE_LOGIN so PBKDF2 login works on NuttX 13.0+. Fixes apache#19573. Signed-off-by: Abhishek Mishra <mishra.abhishek2808@gmail.com>
Abhishekmishra2808
requested review from
GUIDINGLI,
acassis,
anchao,
pussuw and
xiaoxiang781216
as code owners
July 29, 2026 12:30
github-actions
Bot
added
Size: S
xiaoxiang781216
previously approved these changes
Jul 29, 2026
acassis
previously approved these changes
Jul 29, 2026
Contributor
|
@Abhishekmishra2808 should we add the correct dependence to avoid the user enable the incorrect combination? |
Contributor
Yes, CONFIG_NSH_CONSOLE_LOGIN should depends on PASSWD with PBKDF2 enabled |
|
Contributor
Author
|
Agreed @xiaoxiang781216 and @acassis !! |
Abhishekmishra2808
dismissed stale reviews from acassis and xiaoxiang781216
via
July 29, 2026 14:48
d6fd5a1
BOARD_ETC_ROMFS_PASSWD_ENABLE now depends on FSUTILS_PASSWD and a cryptodev backend so PBKDF2 passwd autogen cannot be enabled without the runtime login stack. Fixes apache#19573. Signed-off-by: Abhishek Mishra <mishra.abhishek2808@gmail.com>
Abhishekmishra2808
force-pushed
the
fix/sim-console-login-19573
branch
from
July 29, 2026 14:50
d6fd5a1 to
04364e8
Compare
xiaoxiang781216
approved these changes
Jul 29, 2026
Contributor
Author
|
After merging this, please re-run the CI at apache/nuttx-apps#3679 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enable BOARD_ETC_ROMFS_PASSWD_ENABLE and software cryptodev options on all sim configs with CONFIG_NSH_CONSOLE_LOGIN so PBKDF2 login works on NuttX 13.0+.
Companion PR apache/nuttx-apps#3679
Impact
Fixes broken NSH console login on NuttX 13.0+ for affected sim configs.
After the PBKDF2 login migration (#19209 / #19321), CONFIG_NSH_CONSOLE_LOGIN=y alone is not enough. These configs were missing the ROMFS passwd autogen and software crypto options that sim:login already had, so login failed at runtime (no valid /etc/passwd, or PBKDF2 could not run).
Fixes #19573
Testing