Skip to content

SINGA-138 add clocks for forward and backward functions.#127

Open
daijian wants to merge 3 commits intoapache:masterfrom
daijian:master
Open

SINGA-138 add clocks for forward and backward functions.#127
daijian wants to merge 3 commits intoapache:masterfrom
daijian:master

Conversation

@daijian
Copy link
Copy Markdown

@daijian daijian commented Jan 27, 2016

SINGA-138 add clocks for forward and backward functions.

@daijian daijian changed the title add clocks for forward and backward functions. SINGA-138 add clocks for forward and backward functions. Jan 27, 2016
@wangsheng1001
Copy link
Copy Markdown
Contributor

Hi daijian,

Please kindly follow the guideline below to format your pull request before we can merge it:
http://singa.incubator.apache.org/develop/contribute-code.html

Please include JIRA ticket in your commits and check coding style using cpplint.

Comment thread src/utils/clock.cc
*
*************************************************************/

#include "singa/utils/clock.h"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering this class is simple, maybe we can move the implementation into the .h file..
Timer vs Clock, which one is better?
c++11 has a set of functions related to time in. There could be some functions that are better (more accurate) than clock.

@daijian
Copy link
Copy Markdown
Author

daijian commented Mar 15, 2016

SINGA-138 add clocks for forward and backward functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants