-
Notifications
You must be signed in to change notification settings - Fork 1.3k
SINGA-138 add clocks for forward and backward functions. #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
daijian
wants to merge
3
commits into
apache:master
Choose a base branch
from
daijian:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+164
−2
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| /************************************************************ | ||
| * | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| * | ||
| *************************************************************/ | ||
|
|
||
| #ifndef _SINGA_UTILS_CLOCK_H_ | ||
| #define _SINGA_UTILS_CLOCK_H_ | ||
|
|
||
| #include <string> | ||
|
|
||
| namespace singa { | ||
|
|
||
| class Clock { | ||
| public: | ||
| Clock(); | ||
|
|
||
| void Start(); | ||
|
|
||
| double End(); | ||
| double End(int iteration_num, std::string content); | ||
| void EndWithLog(std::string content); | ||
| void EndWithLog(int iteration_num, std::string content); | ||
|
|
||
| double Elapse(); | ||
| double Elapse(int iteration_num, std::string content); | ||
| void ElapseWithLog(std::string content); | ||
| void ElapseWithLog(int iteration_num, std::string content); | ||
|
|
||
| protected: | ||
| int start_t = -1, end_t = -1; | ||
| }; | ||
|
|
||
|
|
||
| } // namespace singa | ||
|
|
||
|
|
||
|
|
||
|
|
||
| #endif // SINGA_UTILS_CLOCK_H_ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,92 @@ | ||
| /************************************************************ | ||
| * | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| * | ||
| *************************************************************/ | ||
|
|
||
| #include "singa/utils/clock.h" | ||
|
|
||
| #include <glog/logging.h> | ||
| #include <cmath> | ||
| #include <ctime> | ||
| #include "singa/utils/cluster.h" | ||
| #include "singa/utils/factory.h" | ||
| #include "singa/utils/singleton.h" | ||
| #include "singa/utils/context.h" | ||
|
|
||
| namespace singa { | ||
|
|
||
| Clock::Clock() { | ||
| start_t = clock(); | ||
| } | ||
|
|
||
|
|
||
|
|
||
| void Clock::Start() { | ||
| start_t = clock(); | ||
| } | ||
|
|
||
| double Clock::End() { | ||
| end_t = clock(); | ||
| double runtime = (end_t-start_t)/static_cast<double>(CLOCKS_PER_SEC)*1000; | ||
| return runtime; | ||
| } | ||
|
|
||
| double Clock::End(int iteration_num, std::string content) { | ||
| end_t = clock(); | ||
| double runtime = (end_t-start_t); | ||
| runtime = runtime/(static_cast<double>(CLOCKS_PER_SEC)*1000*iteration_num); | ||
| return runtime; | ||
| } | ||
|
|
||
| void Clock::EndWithLog(std::string content) { | ||
| double runtime = end(); | ||
| DLOG(ERROR) << "Running time of " << content<< " is " << runtime << " ms"; | ||
| } | ||
|
|
||
| void Clock::EndWithLog(int iteration_num, std::string content) { | ||
| double runtime = end(iteration_num, content); | ||
| DLOG(ERROR)<< "Average Running time of " << iteration_num; | ||
| DLOG(ERROR)<< " iterations in " << content << " is " << runtime << " ms"; | ||
| } | ||
|
|
||
| double Clock::Elapse() { | ||
| end_t = clock(); | ||
| double runtime = (end_t-start_t)/static_cast<double>(CLOCKS_PER_SEC)*1000; | ||
| return runtime; | ||
| } | ||
|
|
||
| double Clock::Elapse(int iteration_num, std::string content) { | ||
| end_t = clock(); | ||
| double runtime = (end_t-start_t); | ||
| runtime = runtime/(static_cast<double>(CLOCKS_PER_SEC)*1000*iteration_num); | ||
| return runtime; | ||
| } | ||
|
|
||
| void Clock::ElapseWithLog(std::string content) { | ||
| double runtime = end(); | ||
| DLOG(ERROR)<< "Running time of " <<content << " is " << runtime << " ms"; | ||
| } | ||
|
|
||
| void Clock::ElapseWithLog(int iteration_num, std::string content) { | ||
| double runtime = end(iteration_num, content); | ||
| DLOG(ERROR) << "Average Running time of " << iteration_num; | ||
| DLOG(ERROR) << " iterations in " << content << " is " << runtime << " ms"; | ||
| } | ||
|
|
||
| } // namespace singa | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Considering this class is simple, maybe we can move the implementation into the .h file..
Timer vs Clock, which one is better?
c++11 has a set of functions related to time in. There could be some functions that are better (more accurate) than clock.