Fix test src/test/regress/expected/inherit_optimizer.out#2644
Merged
Conversation
There is one more issue in nodeModifyTable.c not fixed by commit 2bd01ef. Tuple routing should normally be done at most once per tuple. ORCA forces tuple routing to be always performed because of dynamic scans. However, INSERT part of split update already does the routing, so we should ignore the forced routing to the wrong partition in case of INSERTs. Also, the routing should only affect the current partition for a single tuple, so resultRelInfo should not be affected. Only update temporary routedResultRelInfo instead, if needed.
RekGRpth
reviewed
Jun 3, 2026
RekGRpth
approved these changes
Jun 3, 2026
bimboterminator1
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is one more issue in nodeModifyTable.c not fixed by commit
2bd01ef. Tuple routing should normally
be done at most once per tuple. ORCA forces tuple routing to be always
performed because of dynamic scans. However, INSERT part of split update
already does the routing, so we should ignore the forced routing to the
wrong partition in case of INSERTs. Also, the routing should only affect
the current partition for a single tuple, so resultRelInfo should not be
affected. Only update temporary routedResultRelInfo instead, if needed.
Also remove outdated assert.