Repository navigation
34585 - corps missing address warnings + reviewImportedData to-do - #4867
Conversation
kialj876
left a comment
kialj876
left a comment
There was a problem hiding this comment.
Looks good to me, just one minor comment below to confirm
| party = party_role.party | ||
| data = {"partyId": party.id} | ||
| result.extend(_with_data( | ||
| check_address(party.mailing_address, Address.MAILING, BusinessWarningReferers.DIRECTOR), data)) |
There was a problem hiding this comment.
I noticed that this check seems to flag a missing postal code unconditionally, whereas postal-code requirements for director addresses are country-specific. Is this accounted for in the new corporation warning logic? Same applies for delivery address check below.
There was a problem hiding this comment.
Good catch, it wasn't. check_address flagged a missing postal code regardless of country. Now it goes through the same NO_POSTAL_CODE_COUNTRY_CODES exemption as _validate_postal_code (moved the constant to services/utils.py so the warnings package can share it without importing the filing validators). Since the check is shared, firm party/office warnings get the same fix. Added cases for CA/US/HK/AE/unresolvable country on both the firms and corps side.
|
3 participants
*Issue:*bcgov/entity#34585
Description of changes: Corps now emit MISSING_REQUIRED_BUSINESS_INFO warnings (with officeType / partyId data) for registered/records office and active director addresses, and GET /tasks adds a reviewImportedData to-do when they exist and no draft is pending.