fix(android): resolve signUpWithPassword with a WritableMap - #25
Merged
benjamineruvieru merged 1 commit intoSep 17, 2026
Conversation
Contributor
Author
Owner
|
Thank you for your contribution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23.
Problem
On Android,
signUpWithPasswordsaves the credential and then crashes the app when it resolves the promise:The success result is built with Kotlin
mapOf(...), which is ajava.util.LinkedHashMap.Promise.resolveonly accepts primitives andWritableMap/WritableArray, so it throws. The exception is raised inside the coroutine, so it takes down the process and can't be caught from JS. The other methods (signIn,createPasskey) already build their results withArguments.createMap(), so onlysignUpWithPasswordis affected.Change
Build the result with
Arguments.createMap()in both the new and old architecture modules. The shape resolved to JS is unchanged:{ type: "password", username, success: true }.We've been running this as a
pnpm patchon 0.8.1 in production (Expo SDK 57, React Native 0.86, New Architecture). Saving a password after sign-up and after email login no longer crashes.