Skip to content

fix(android): resolve signUpWithPassword with a WritableMap #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benjamineruvieru merged 1 commit into from
Sep 17, 2026
Merged

fix(android): resolve signUpWithPassword with a WritableMap #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions android/src/newarch/java/com/credentialsmanager/CredentialsManagerModule.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import androidx.credentials.exceptions.GetCredentialException
import androidx.credentials.exceptions.NoCredentialException
import com.credentialsmanager.handlers.CredentialHandler
import com.credentialsmanager.handlers.ErrorHandler
import com.facebook.react.bridge.Arguments
import com.facebook.react.bridge.Promise
import com.facebook.react.bridge.ReactApplicationContext
import com.facebook.react.bridge.ReadableArray
Expand Down Expand Up @@ -68,11 +69,11 @@ class CredentialsManagerModule(
credentialHandler.createPassword(username, password)

// Create success response
val result = mapOf(
"type" to "password",
"username" to username,
"success" to true
)
val result = Arguments.createMap().apply {
putString("type", "password")
putString("username", username)
putBoolean("success", true)
}
promise.resolve(result)
} catch (e: CreateCredentialException) {
ErrorHandler.handleCredentialError(e)
Expand Down
11 changes: 6 additions & 5 deletions android/src/oldarch/java/com/credentialsmanager/CredentialsManagerModule.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import androidx.credentials.exceptions.GetCredentialException
import androidx.credentials.exceptions.NoCredentialException
import com.credentialsmanager.handlers.CredentialHandler
import com.credentialsmanager.handlers.ErrorHandler
import com.facebook.react.bridge.Arguments
import com.facebook.react.bridge.Promise
import com.facebook.react.bridge.ReactApplicationContext
import com.facebook.react.bridge.ReactContextBaseJavaModule
Expand Down Expand Up @@ -74,11 +75,11 @@ class CredentialsManagerModule(
credentialHandler.createPassword(username, password)

// Create success response
val result = mapOf(
"type" to "password",
"username" to username,
"success" to true
)
val result = Arguments.createMap().apply {
putString("type", "password")
putString("username", username)
putBoolean("success", true)
}
promise.resolve(result)
} catch (e: CreateCredentialException) {
ErrorHandler.handleCredentialError(e)
Expand Down
Loading