Fix slider pointer capture - #25772
Merged
alice-i-cecile merged 2 commits intoSep 15, 2026
Merged
Conversation
viridia
approved these changes
Sep 14, 2026
viridia
left a comment
Contributor
There was a problem hiding this comment.
Seems fine - @alice-i-cecile Would this also fall under your "low value test" criteria?
Contributor
|
Also, needs an LLM disclosure in the description. |
alice-i-cecile
approved these changes
Sep 14, 2026
Contributor
Author
I added LLM disclosure |
gregcsokas
pushed a commit
to gregcsokas/bevy
that referenced
this pull request
Sep 21, 2026
## Objective * Make sliders capture the pointer when dragging, so dragging continues correctly even when the pointer moves outside the slider's hit area. * Fixes bevyengine#25705. ## Solution * Capture the pointer when a slider receives `PointerDragStart`. * Release the pointer when the drag ends. * Added a regression test verifying that the slider captures the pointer on drag start. ## Testing * Ran the focused slider pointer-capture test successfully. * Ran the full `bevy_ui_widgets` test suite successfully with `cargo test -p bevy_ui_widgets`. * Ran `git diff --check` successfully. * No platform-specific behavior is expected from this change. ## AI disclosure I used an LLM only as a final code reviewer to improve any non rust-idiomatic code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution
PointerDragStart.Testing
bevy_ui_widgetstest suite successfully withcargo test -p bevy_ui_widgets.git diff --checksuccessfully.AI disclosure
I used an LLM only as a final code reviewer to improve any non rust-idiomatic code