Implement ReadOnlySystemParam for PopulatedMessageReader - #25775
Merged
alice-i-cecile merged 1 commit intoSep 15, 2026
Merged
Conversation
Contributor
|
Welcome, new contributor! Please make sure you've read our contributing guide, as well as our policy regarding AI usage, and we look forward to reviewing your pull request shortly ✨ |
alice-i-cecile
added
D-Trivial
alice-i-cecile
approved these changes
Sep 14, 2026
ItsDoot
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #25759
PopulatedMessageReadercan't be used in run conditions because it doesn't implementReadOnlySystemParam.Solution
Implement the trait, as it is safe to do because all world access is delegated to its inner
MessageReader, which already implements it.Testing
Verified that using a function taking
PopulatedMessageReaderin a.run_ifcondition now compiles correctly.