Simplify system dependency - #25776
Merged
alice-i-cecile merged 6 commits intoSep 15, 2026
Merged
Conversation
Trashtalk217
added
D-Trivial
alice-i-cecile
added
the
S-Needs-Review
alice-i-cecile
added
X-Uncontroversial
| /// Systems are chained. `before -> after` ordering constraints | ||
| /// will be added between the successive elements. | ||
| Chained(TypeIdHashMap<Box<dyn Any>>), | ||
| Chained { |
Member
There was a problem hiding this comment.
Technically a breaking change but eh...
alice-i-cecile
approved these changes
Sep 14, 2026
alice-i-cecile
left a comment
alice-i-cecile
left a comment
Member
There was a problem hiding this comment.
Good choice! Migration guide is technically useful, but also this is extremely niche.
ItsDoot
approved these changes
Sep 14, 2026
ItsDoot
left a comment
ItsDoot
left a comment
Contributor
There was a problem hiding this comment.
The change itself is fine (other than the doc nits), but I think we should see if anyone is using it for their own purposes 🤔
Co-authored-by: Christian Hughes <9044780+ItsDoot@users.noreply.github.com>
Contributor
Author
|
Since |
alice-i-cecile
added
S-Ready-For-Final-Review
Member
|
CI failure is real but trivial. |
Member
|
Fixed CI myself :) Merging. |
alice-i-cecile
enabled auto-merge
September 15, 2026 20:31
gregcsokas
pushed a commit
to gregcsokas/bevy
that referenced
this pull request
Sep 21, 2026
# Objective In bevyengine#11094 a schedule build pass was added. This PR included abstractions for specifiying options for `Dependency`s. This was slightly over engineered, since in the meantime, this field wasn't used for anything more than `Weak` dependencies and `IgnoreDeferred`. ## Solution Remove `options` and add `is_weak` and `ignore_deferred` to `Dependency`. ## Testing Covered by existing tests. --------- Co-authored-by: Christian Hughes <9044780+ItsDoot@users.noreply.github.com> Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
In #11094 a schedule build pass was added. This PR included abstractions for specifiying options for
Dependencys. This was slightly over engineered, since in the meantime, this field wasn't used for anything more thanWeakdependencies andIgnoreDeferred.Solution
Remove
optionsand addis_weakandignore_deferredtoDependency.Testing
Covered by existing tests.