Repository navigation
Add register_dependent_types for BTreeMap - #25777
Merged
Merged
Conversation
alice-i-cecile
added
D-Trivial
alice-i-cecile
approved these changes
Sep 14, 2026
Diddykonga
approved these changes
Sep 14, 2026
viridia
added a commit
to viridia/bevy_action_map
that referenced
this pull request
Sep 16, 2026
bevyengine/bevy#25777 adds register_type_dependencies to BTreeMap's GetTypeRegistration, so registering SavedOverrides now reaches the inner map's value type on its own. The two calls naming BTreeMap<String, SavedRow> and BTreeMap<String, SavedTunableValue> go away, along with the half of the comment that justified them. Moves the Bevy pin from ac70f41d to 997c1b6b to pick the fix up, which carries a batch of crates.io bumps with it. The persistence tests do not probe this either way: the bevy dev-dependency's default features enable bevy_reflect/auto_register_inventory for every build in this repo, so SavedOverrides registers itself there regardless. That also makes docs/issues.md 1019's "that mechanism is inert here" wrong for dev and downstream builds, which chunk 109 still owns. LLM Usage Disclosure: implementation, tests and documentation written by Claude Opus 5; design decisions, review and acceptance by the author.
gregcsokas
pushed a commit
to gregcsokas/bevy
that referenced
this pull request
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #25771