Solari: Denoiser motion vector metal compat - #25787
Merged
Merged
Conversation
stuartparmenter
approved these changes
Sep 14, 2026
Contributor
|
Would like to land this in 0.20 so solari on metal isn't broken |
JMS55
suggested changes
Sep 15, 2026
JMS55
suggested changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
It changed Solari’s motion vectors from a sampled
texture_2d<f32>totexture_storage_2d<rg16float, read_write>.Presently on main we get a crash on Metal:
rg16floatcan't be bound as a read-write storage texture on Metal. Vulkan and DX12 usually can.Solution
ReSTIR only samples motion vectors to reproject last frame's reservoir. The only writer is DLSS Ray Reconstruction PSR, and only for perfect mirrors — everything else already goes to
specular_motion_vectors.At pipeline init we check whether the adapter supports
STORAGE_READ_WRITEonrg16float. If it does, we keep the storage binding and write PSR motion in place. If not, we sample atexture_2d<f32>and skip the write. DLSS RR doesn't run on those GPUs anyway.Testing
DLSS_SDK/ NVIDIA GPU on this machine)