fix(entergame): recreate character list after relog - #31
Merged
Conversation
This was referenced Jul 25, 2026
blakinio
force-pushed
the
fix/OTC-20260726-characterlist-recreation
branch
from
July 26, 2026 06:27
8baa23d to
6e30c34
Compare
blakinio
force-pushed
the
fix/OTC-20260726-characterlist-recreation
branch
from
July 26, 2026 06:32
c01a7da to
ce4329e
Compare
blakinio
marked this pull request as ready for review
July 26, 2026 06:37
blakinio
enabled auto-merge (squash)
July 26, 2026 06:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Repair the confirmed character-list lifecycle failure where closing the list after logout leaves no window for the next
showAgain()callback and the resource resolver can turn relativecharacterlistinto the invalid root path/characterlist.otui.Task
OTC-20260726-characterlist-recreationdocs/agents/tasks/active/OTC-20260726-characterlist-recreation.mdce4329ee13b39576915240605c2fe6657096c517backup/OTC-20260726-characterlist-recreation-pre-restackandbackup/OTC-20260726-characterlist-recreation-clean-c01a7daaScope
/client_entergame/, even whenguessFilePathreturns a root-level pathG.characters/G.characterAccountVerified diff
Exactly eight files: lifecycle helper/adapter, one manifest line, two Lua tests, two CTest entries, changelog and task record. Historical upstream stack was removed; branch is current with
main.Safety
Validation
Exact-head Lua Syntax, focused CTest, five Windows variants and
CI / Requiredmust pass. Auto-merge remains branch-protection gated.