Skip to content

fix(entergame): recreate character list after relog - #31

Merged
blakinio merged 16 commits into
mainfrom
fix/OTC-20260726-characterlist-recreation
Jul 26, 2026
Merged

fix(entergame): recreate character list after relog#31
blakinio merged 16 commits into
mainfrom
fix/OTC-20260726-characterlist-recreation

Conversation

@blakinio

@blakinio blakinio commented Jul 25, 2026

Copy link
Copy Markdown
Owner

Purpose

Repair the confirmed character-list lifecycle failure where closing the list after logout leaves no window for the next showAgain() callback and the resource resolver can turn relative characterlist into the invalid root path /characterlist.otui.

Task

  • Task: OTC-20260726-characterlist-recreation
  • Task record: docs/agents/tasks/active/OTC-20260726-characterlist-recreation.md
  • Clean base: ce4329ee13b39576915240605c2fe6657096c517
  • Backup refs: backup/OTC-20260726-characterlist-recreation-pre-restack and backup/OTC-20260726-characterlist-recreation-clean-c01a7daa

Scope

  • anchor every relative legacy/Oteryn layout under /client_entergame/, even when guessFilePath returns a root-level path
  • preserve explicit absolute layouts and reject traversal
  • preserve the last selected layout
  • recreate destroyed UI from existing G.characters / G.characterAccount
  • fail safely back to EnterGame when layout creation fails
  • focused core and full adapter lifecycle tests

Verified diff

Exactly eight files: lifecycle helper/adapter, one manifest line, two Lua tests, two CTest entries, changelog and task record. Historical upstream stack was removed; branch is current with main.

Safety

  • no authentication, credential, protocol, server or asset changes
  • existing CharacterList remains the only population/login controller
  • PR feat(ui): prototype Oteryn login shell #23 presentation behavior will be reconciled onto this manifest load-order fix

Validation

Exact-head Lua Syntax, focused CTest, five Windows variants and CI / Required must pass. Auto-merge remains branch-protection gated.

@blakinio blakinio closed this Jul 26, 2026
@blakinio
blakinio force-pushed the fix/OTC-20260726-characterlist-recreation branch from 8baa23d to 6e30c34 Compare July 26, 2026 06:27
@blakinio blakinio reopened this Jul 26, 2026
@blakinio blakinio closed this Jul 26, 2026
@blakinio
blakinio force-pushed the fix/OTC-20260726-characterlist-recreation branch from c01a7da to ce4329e Compare July 26, 2026 06:32
@blakinio blakinio reopened this Jul 26, 2026
@blakinio
blakinio marked this pull request as ready for review July 26, 2026 06:37
@blakinio
blakinio enabled auto-merge (squash) July 26, 2026 06:38
@blakinio
blakinio merged commit a9a03b8 into main Jul 26, 2026
14 checks passed
@blakinio
blakinio deleted the fix/OTC-20260726-characterlist-recreation branch July 26, 2026 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant