fix(track-a): fence canonical lease post-merge races - #313
Merged
blakinio merged 9 commits intoAug 15, 2026
Conversation
blakinio
marked this pull request as ready for review
August 15, 2026 21:17
blakinio
deleted the
fix/OTC-20260815-track-a-live-runtime-lease-postmerge-p1
branch
August 15, 2026 21:19
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e5c1addad5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This was referenced Aug 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Post-merge remediation for task
OTC-20260815-track-a-live-runtime-lease-manager, based onmain@3575cc0c0a0b4efbcd9fc860d3226002fe40e70fafter PR #312 merged.Material findings addressed
Two P1 review findings landed on merged PR #312:
guard-runcould release the coordination flock if its parent died while the guarded child continued running.Fix
locked()now yields the live flock FD;guard-runpasses that FD to the guarded child, so the child cannot outlive the serialization lock if the guard parent is killed;acquire,renew,release,validate,status, andguard-runnow sample time only after the flock is acquired;Focused validation
Temporary branch-only remediation run
31908781559, job95070594733: SUCCESS. The workflow applied the patch, ran the full lease unit suite, ranpy_compile, committed the result, and was then removed from the branch. Final changed paths are only the manager implementation, its unit tests, and the active task record.No Tibia client/runtime process, production canonical state, PR #303/#309 path, Track B path, or owner-funded AI/API quota is touched.
PR #311 remains fail-closed until this remediation is independently reviewed, protected CI passes, and the fix reaches
main.