Skip to content

fix(options): repair deterministic Phase 0 defects - #36

Merged
blakinio merged 1 commit into
mainfrom
fix/OTC-20260726-options-phase0
Jul 27, 2026
Merged

fix(options): repair deterministic Phase 0 defects#36
blakinio merged 1 commit into
mainfrom
fix/OTC-20260726-options-phase0

Conversation

@blakinio

@blakinio blakinio commented Jul 25, 2026

Copy link
Copy Markdown
Owner

Purpose

Repair deterministic option defects without exposing unsupported product surface.

Task

  • Task: OTC-20260726-options-phase0
  • Clean base: 3c7d1a75d294fce027c1f45f963f4aac4970b2fc
  • Previous exact-head backup: backup/OTC-20260726-options-phase0-pre-20260727-restack-2

Scope

  • map Right Bar 3 reset to action bar 9 and give the global reset button a unique ID
  • own/cancel the inventory-expiry reload event independently
  • normalize teleport/floor-change and cooldown labels
  • hide controls without authoritative backing behavior
  • introduce canonical showExpiryInInventory with legacy showExpiryInInvetory dual-read/write compatibility
  • focused Lua/static coverage

Verified diff

Exactly eight files: two option helpers, one manifest change, one focused OTUI correction, one test plus CTest registration, changelog and task record. The historical stack remains excluded.

Safety

  • no protocol, authentication, renderer, Canary or server changes
  • unsupported controls remain hidden
  • existing misspelled-key consumers remain supported

Validation

Current head: 8f1f03bcf506d7846c3e344dc25df9b7c7a305a7.

Exact-head Lua Syntax, Windows CMake Tests/CTest, full required Windows matrix and CI / Required must pass before squash merge. Run 30223541591 belongs to the superseded head and is not merge evidence.

@blakinio blakinio closed this Jul 26, 2026
@blakinio
blakinio force-pushed the fix/OTC-20260726-options-phase0 branch from ce81b2d to ca78b71 Compare July 26, 2026 16:29
@blakinio blakinio reopened this Jul 26, 2026
@blakinio
blakinio marked this pull request as ready for review July 26, 2026 16:35
@blakinio
blakinio enabled auto-merge (squash) July 26, 2026 16:35
@blakinio
blakinio force-pushed the fix/OTC-20260726-options-phase0 branch from 4f178ad to 5f5e615 Compare July 26, 2026 22:38
@blakinio
blakinio force-pushed the fix/OTC-20260726-options-phase0 branch from 5f5e615 to 8f1f03b Compare July 26, 2026 23:25
@blakinio
blakinio merged commit 99ad5de into main Jul 27, 2026
14 checks passed
@blakinio
blakinio deleted the fix/OTC-20260726-options-phase0 branch July 27, 2026 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant