Allow dev-command arguments and desktop port selection - #109
Merged
Merged
Conversation
added 2 commits
September 21, 2026 13:37
Signed-off-by: Brain <1a02c72794dcd0f07058a353bc3a81f4028b8c77c92c87fce6d5c8b85970a20b@buzz.block.builderlab.xyz>
Signed-off-by: Brain <1a02c72794dcd0f07058a353bc3a81f4028b8c77c92c87fce6d5c8b85970a20b@buzz.block.builderlab.xyz>
Contributor
|
Integration update: #111 is notification-only. Dock labels are now implemented in draft PR #113, stacked on this PR’s shared desktop launcher. It preserves this argument/port interface and inherited package-manager/termination path; content-keyed icons fix warm-build invalidation. No code changes are requested here for Dock labels. After #109 merges, #113 will need retargeting to main and revalidation. The mistakenly created tracker #112 is closed; #113 is the implementation. |
Signed-off-by: Brain <1a02c72794dcd0f07058a353bc3a81f4028b8c77c92c87fce6d5c8b85970a20b@buzz.block.builderlab.xyz>
added 3 commits
September 21, 2026 17:04
Signed-off-by: Brain <1a02c72794dcd0f07058a353bc3a81f4028b8c77c92c87fce6d5c8b85970a20b@buzz.block.builderlab.xyz>
Signed-off-by: Brain <1a02c72794dcd0f07058a353bc3a81f4028b8c77c92c87fce6d5c8b85970a20b@buzz.block.builderlab.xyz>
Signed-off-by: Brain <1a02c72794dcd0f07058a353bc3a81f4028b8c77c92c87fce6d5c8b85970a20b@buzz.block.builderlab.xyz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created by Brain on behalf of Wes.
Summary
Allow multiple Buzz development copies to select different frontend ports:
just desktop --port 1430 # In another terminal/worktree: just desktop --port 1431 --no-watch just web --port 1432 --host 127.0.0.1just webto Vite andjust desktopto Tauri, using positional arguments rather than shell interpolation.--port N/--port=Ninto matching TauridevUrland VitebeforeDevCommandsettings. Tauri's own--portcontrols its static-file server and would not configure Vite.--. Generated port configuration is prepended, before Tauri’s implicit runner-argument boundary. Explicit user--configvalues merge afterward and can override it. Runner-owned--portarguments need an explicit--boundary.Validation
Checked at
982e7cd52f5ffff5350c6771a993292cf14123b9:bin/node --test tests/integration/dev-commands.test.mjs: 15 tests passed, executing the real just recipes and desktop adapter against a recording package-manager boundary. Includes default behavior, both port syntaxes, boundaries, invalid input, quoting, config order, and runner/application argument pass-through.just web --port ...servers and two realjust desktop --port ... --no-watch --runner <stub>frontend servers responded concurrently. Captured Tauri's effective config confirmed matching port/URL, correct parsing even with implicit runner arguments, and preservation of an unrelated productName override.just desktop --helpforwarded successfully.node --test tests/integration/*.test.mjs.Native compilation and actual simultaneous native windows were not exercised: the smoke used the real Tauri CLI and Vite but substituted only the native runner. No live identity/relay activity. Full CI and code-owner approval remain separate gates.
Originating Buzz conversation: channel
3428ec3f-a58b-429b-afbc-dc6a77918ce8, thread0470bf23405c699a93bba2d83a3791cfc50e6a1d5d63205761e1cb191a640094.CI follow-up at
8e4e74acc39a234c475d60f046aca09d1e85c9749053fa9, incorporating test(browser): scroll past tall rows before asserting a new reading row #110. All four browser-journey jobs then passed, including the previously failing reading-anchor assertion.terminal::tests::bounded_input_and_session_admissionduring first PTY spawn with “nul byte found in provided data.” Its Node integration step was skipped. Failed Rust job.src-tauri/src/terminal/tests.rs: both shell fixtures clone oneOnceLock-initialized command with explicit HOME/SHELL. Locked portable-pty 0.9.0 otherwise calls non-reentrantgetpwuidduring construction when parent SHELL is absent and at spawn when HOME/SHELL are omitted. The template prevents concurrent fixture constructor lookups; explicit values avoid spawn fallback lookups. No production changes, serial test mode, retries, or weakened assertions.bin/cargo test -p buzz-foundation --lib --locked terminal::tests -- --nocapturepassed all 11 terminal tests (3 unrelated native tests filtered out). Cold build 38.68s; test execution 0.73s. This is focused validation, not a full package-suite claim; CI owns broad coverage.8e4e74a/ tests blob4e7456e8ac81477dd81ba758b331a729ac97bd72reports no blocking findings. Formatting and diff checks passed; mandatory hooks passed, with no JS/design tests selected by pre-push.Refreshed integration head
8d5afc5726f4df8d4f22c3db9615711afb379f82Main advanced during the repair and introduced a contributing.md conflict, which prevented PR CI from starting at
8e4e74a. Merged main0b73a45, preserving both port documentation and local-notification guidance. The terminal fixture blob is unchanged. At this refreshed head, all 11 terminal tests (8 unrelated native tests filtered) and all 15 dev-command integration tests pass locally. That CI run completed: Rust/tool integration passed, including the previously failing admission test; Chromium shard 1 instead failed the agent-activity tooltip teardown/layout assertion described below.Tooltip teardown repair at
a5eb7da9eeb72c069f48937dfe53acda6dbcf5abagent-activity.spec.mjspassed in Chromium and WebKit: 10/10, 21.4s locally. Exact test SHA256:40bcd0cfcd49f7882e727bac9a887b8c78b493265a614554ae0981b67202f7e2. This is focused browser validation, not the full repository suite.