monitor: ignore short non-gluon vendor IEs without logging an error - #13
Merged
blocktrron merged 1 commit intoMay 16, 2026
Merged
Conversation
The IE parser checked ie_len < 9 and log_error()'d "IE is too short." before validating the OUI, so any third-party vendor-specific IE (tag 0xdd) shorter than 9 bytes was logged as an error even though it was never destined for us. WiFi scans routinely showed such IEs from other devices. Validate only the 6 bytes needed for the OUI/type compare first, then re-check the full length after the IE is confirmed to be a gluon node IE so a genuinely truncated one is still logged as an error. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The IE parser checked ie_len < 9 and log_error()'d "IE is too short." before validating the OUI, so any third-party vendor-specific IE (tag 0xdd) shorter than 9 bytes was logged as an error even though it was never destined for us. WiFi scans routinely showed such IEs from other devices.
Validate only the 6 bytes needed for the OUI/type compare first, then re-check the full length after the IE is confirmed to be a gluon node IE so a genuinely truncated one is still logged as an error.