Skip to content

monitor: ignore short non-gluon vendor IEs without logging an error #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blocktrron merged 1 commit into from
May 16, 2026
Merged

monitor: ignore short non-gluon vendor IEs without logging an error #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/monitor.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,8 +360,9 @@ static int monitor_gluon_node_parse_ie(const uint8_t *ie, size_t ie_len, void *d
return 0;
}

if (ie_len < 6 + 3) {
log_error("IE is too short.");
/* Need header + OUI + vendor type before inspecting vendor-specific fields */
if (ie_len < 6) {
log_debug("Vendor IE too short to inspect OUI.");
return 0;
}

Expand All @@ -375,6 +376,11 @@ static int monitor_gluon_node_parse_ie(const uint8_t *ie, size_t ie_len, void *d
return 0;
}

if (ie_len < 6 + 3) {
log_error("Gluon node IE is too short.");
return 0;
}

log_debug("Found gluon node IE length=%d", gluon_tlv_len);

/* Validate TLVs. We can re-use the ieee80211 helper for this */
Expand Down
Loading