Don't derive the archive exceptions virtually - #373
Open
gennaroprota wants to merge 1 commit into
Open
Conversation
`archive_exception` derived virtually from `std::exception`, and `xml_archive_exception` from `archive_exception` in turn, which gives both classes an implicit vbase destructor. MSVC and Clang disagree about whether the DLL owns that function or the consumer: cl never exports it and lets every consumer synthesize its own, while clang-cl exports it with the class and imports it. Therefore, a program built with clang-cl against a library built with cl failed to link. Since virtual inheritance didn't buy much here, this removes it, leaving nothing for the two compilers to disagree about. Fixes #321.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
archive_exceptionderived virtually fromstd::exception, andxml_archive_exceptionfromarchive_exceptionin turn, which gives both classes an implicit vbase destructor. MSVC and Clang disagree about whether the DLL owns that function or the consumer: cl never exports it and lets every consumer synthesize its own, while clang-cl exports it with the class and imports it. Therefore, a program built with clang-cl against a library built with cl failed to link.Since virtual inheritance didn't buy much here, this removes it, leaving nothing for the two compilers to disagree about.
Fixes #321.