Skip to content

Don't derive the archive exceptions virtually #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gennaroprota wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Don't derive the archive exceptions virtually #373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion include/boost/archive/archive_exception.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,11 @@ namespace archive {
//////////////////////////////////////////////////////////////////////
// exceptions thrown by archives
//
// The base is deliberately not virtual: a virtual one would give the
// class an implicit vbase destructor, which cl and clang-cl expect to
// find in different modules. See issue #321.
class BOOST_SYMBOL_VISIBLE archive_exception :
public virtual std::exception
public std::exception
{
private:
char m_buffer[128];
Expand Down
4 changes: 3 additions & 1 deletion include/boost/archive/xml_archive_exception.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,10 @@ namespace archive {
//////////////////////////////////////////////////////////////////////
// exceptions thrown by xml archives
//
// The base is deliberately not virtual, for the reason given in
// archive_exception.hpp. See issue #321.
class BOOST_SYMBOL_VISIBLE xml_archive_exception :
public virtual boost::archive::archive_exception
public boost::archive::archive_exception
{
public:
typedef enum {
Expand Down