fix(lib): record success events for 9 tools misusing trackMCP

[SavioBS629]

Summary

Nine tools call trackMCP(name, clientInfo, config) on the success path, dropping the error argument. trackMCP's signature is (toolName, clientInfo, error?, config?), so on every successful call:

• config lands in the error slot → success=false
• config itself is undefined → no Authorization header → the event is never stored

Result: 30 days of MCPInstrumentation data contain zero success=true rows for these tools, so analytics show them failing 100% of the time (see #proj-mcp thread from Bharti on fetchBuildInsights / runTestsOnBrowserStack). Correctly instrumented tools (getFailureLogs, listSessions, …) show both outcomes in the same window.

Affected call sites:

• src/tools/build-insights.ts — fetchBuildInsights
• src/tools/bstack-sdk.ts — setupBrowserStackAutomateTests
• src/tools/percy-sdk.ts — all seven Percy tools (including the single-line listTestFiles and runPercyScan calls flagged in review)

Changes

• Pass undefined explicitly as the error argument at the nine success-path call sites.
• Align tracked names with registered tool names (drifted after renames):
  • runTestsOnBrowserStack → setupBrowserStackAutomateTests
  • VisualTestIntegrationAgent → percyVisualTestIntegrationAgent
  • setupPercyVisualTesting → expandPercyVisualTesting

No behavioural change for end users; telemetry only.

Heads-up for analytics

Dashboards/sheets keyed on the three old names will see the new names from the release that ships this. Historic success counts for these tools cannot be backfilled.

Test plan

• npm run build (lint + format + test + tsc) green on Node 22: 47 files / 649 tests
• Verified no remaining trackMCP( calls pass config in the third position
• Verified registered name == tracked name == handleMCPError name for every tool in the three files

🤖 Generated with Claude Code

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited), Workspace UI (inherited)

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 7bbbfd07-d54a-4abd-a37b-19ad487872dd

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands.}