Suggestion to create base class for key-value storages 2

[afilippov1985]

It is renewed PR #676.

Rewritten storages:

• Cassandra
• CouchbaseDB
• Redis

Added storages:

• Memcached
• MongoDB

[danopz]

I like this approach. Could you add some very descriptive doc-blocks in that change pls. 😄

[bshaffer]

This is awesome! a few things

• we need to convert the tabs to spaces
• have you considered using traits instead of a base class?

[afilippov1985]

Hmm.. I don't see any tabs.
Unfortunately, traits can't implement interfaces. So we can't use instanceof to check whether class implements such interface.

[afilippov1985]

though... storage class can declare that it implements interfaces, but actual implementation will be done by trait.
Then ... would be better to create several traits (one for each interface), each will implement corresponding interface.
No, it was a bad idea.

[bshaffer]

Yes, that is what I had in mind! This is tricky though because this would
break compatibility with PHP 5.3.
On Wed, Jan 13, 2016 at 3:12 AM afilippov1985 notifications@github.com
wrote:

though... storage class can declare that it implements interfaces, but
actual implementation will be done by trait.
Then ... would be better to create several traits (one for each
interface), each will implement corresponding interface.

—
Reply to this email directly or view it on GitHub
#697 (comment)
.

[afilippov1985]

Yes, I also wanted to mention about this. Traits require PHP >=5.4

[afilippov1985]

Oops... travis not working [https://travis-ci.org/bshaffer/oauth2-server-php/jobs/102334251]

[afilippov1985]

Waiting for PR #701

[bluebaroncanada]

So, with #701, this is passing?

[afilippov1985]

Rechecked.
Yes, it passes tests.
Current develop branch also passes tests with #701

[bluebaroncanada]

So @bshaffer, unless you say otherwise, I'll merge this and #701 in about a week.

[svycka]

Is there a reason for underscore before method name?

[afilippov1985]

I removed underscores to conform PSR-2 style

[afilippov1985]

@bluebaroncanada
I think this code is ready to be merged.
Current installations that uses Cassandra, Couchbase or Redis storage will not notice changes (I hope).

[afilippov1985]

@bluebaroncanada @bshaffer
Then I want to discuss #675 (first comment) to make interfaces consistent in v2.x