Skip to content

fix(e2e): the Events tab test reads every /v1/events body before the page closes - #1008

Merged
V3RON merged 2 commits into
mainfrom
bug/1005
Oct 25, 2026
Merged

V3RON merged 2 commits into
mainfrom
bug/1005

Conversation

@V3RON

@V3RON V3RON commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

Closes #1005

Status

Implement: done (1/1 green) Review: round 1 passed, 0 findings Hardware: n/a Gate: running
Next: gate

Done when

  • The Events tab test passes on every run of an unchanged commit. — every /v1/events body read is now awaited before the page closes and the listener comes off before the host part, so the read that failed in CI cannot outlive the page; checked by the code review from source and by CI (the race does not reproduce locally on demand)

Assumptions

  • Assumption: the reproduction spec is deleted — the fixed reader awaits its reads before the page closes, so the repro no longer exercises the lane's code.

Review

Spec review: 0 blocking, 0 fixed, 0 notes. Code review: 0 blocking, 0 fixed, 0 notes. Claims review: 0 blocking, 0 fixed, 0 notes.
Rounds: 1. Tokens: 5.4M.
Runs: 6. Cost USD: 0.879. Agent seconds: 415.

Assessment: complete

Written by an agent.

V3RON added 2 commits October 25, 2026 15:02
…r has not read when host.dispose() closes the page escapes as a test failure
@V3RON

V3RON commented Oct 25, 2026

Copy link
Copy Markdown
Contributor Author

Review ledger

Round 1: 2c4e034

Runs: 6. Cost USD: 0.879. Agent seconds: 415.
Tokens input 92, output 19226, cache read 1003921, cache write 175216.
- build implementer: claude-sonnet-5-5 140 s $0.1513
- audit implementer: claude-sonnet-5-5 22 s $0.0642
- review 1 reviewer: claude-sonnet-5-5 146 s $0.2069
- review 1 spec: claude-sonnet-5-5 14 s $0.0783
- review 1 code both: claude-opus-5-5 69 s $0.2963
- review 1 claims: claude-sonnet-5-5 24 s $0.082
Finding outcomes: {}. Classes: {}.
{"findings":[]}

Written by an agent.

@V3RON
V3RON marked this pull request as ready for review October 25, 2026 14:10
@V3RON
V3RON merged commit e1f2f43 into main Oct 25, 2026
54 checks passed
@V3RON
V3RON deleted the bug/1005 branch October 25, 2026 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky: the workers page Events tab test closes the page before a response is read

1 participant