Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions e2e/console/workers.spec.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type { Locator, Page } from "@playwright/test";
import type { Locator, Page, Response } from "@playwright/test";

import { waitFor } from "../helpers/wait.js";
import {
Expand Down Expand Up @@ -823,12 +823,16 @@ test.describe("the workers page", () => {
const url = new URL(request.url());
if (url.pathname === "/v1/events") asked.push(url.search);
});
page.on("response", (response) => {
const reads: Promise<void>[] = [];
const readEvents = (response: Response) => {
if (new URL(response.url()).pathname !== "/v1/events") return;
void response.json().then((body: { events?: (typeof answered)[number][] }) => {
answered.push(...(body.events ?? []));
});
});
reads.push(
response.json().then((body: { events?: (typeof answered)[number][] }) => {
answered.push(...(body.events ?? []));
}),
);
};
page.on("response", readEvents);
// why: a page of older events holds 100, so more than 100 of worker A's own are needed.
for (let round = 0; round < 25; round += 1) {
const granted = await fleet.gateway.cli([
Expand Down Expand Up @@ -867,6 +871,9 @@ test.describe("the workers page", () => {
expect(asked.filter((query) => !query.includes(`worker=${encodeURIComponent(idA)}`))).toEqual(
[],
);
// why: a body still unread when host.dispose() closes the page would reject the test.
page.off("response", readEvents);
await Promise.all(reads);
expect(answered.length).toBeGreaterThan(100);
expect(answered.filter((event) => event.payload?.workerId !== idA)).toEqual([]);

Expand Down
Loading