feat: Add advice override for 'MISSING_TRIGGER_FUNCTION' - #1352
Merged
TimothyJones merged 2 commits intoJul 18, 2026
Merged
Conversation
TimothyJones
approved these changes
Jul 17, 2026
TimothyJones
left a comment
TimothyJones
left a comment
Member
There was a problem hiding this comment.
Looks good! One minor change request and I'll get this released
| import { Assertable } from '../../entities/types'; | ||
| import { CaseFailedAssertionError } from '../../entities'; | ||
|
|
||
| const advice = (context: MatchContext) => |
Member
There was a problem hiding this comment.
let's call this missingTriggerAdvice, as it's defined quite a long way from where it's used.
TimothyJones
changed the title
Member
|
Update: I merged and did the rename. I'll get this out shortly. |
Merged
Member
|
Released in 0.30.1 in both Maven and npm. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
I support an internal wrapper library around Contract Case.
I want to provide custom error messages on particular failures so that I can give internal users guidance on how to fix their problem in the context of our wrapper library.
Advice overrides are already supported for
MISSING_REGISTERED_FUNCTION(source), but not forMISSING_TRIGGER_FUNCTION.Done in this PR
Added support for custom advice overrides for the error code
MISSING_TRIGGER_FUNCTION.Behaviour of the change was manually verified by testing it in my project that uses Contract Case.